Skip to content

[pull] dev from mrdoob:dev #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 1 commit into from
Mar 21, 2026
Merged

[pull] dev from mrdoob:dev #1223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 18 additions & 38 deletions examples/jsm/renderers/Projector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,18 +310,18 @@ class Projector {
const v2 = _vertexPool[ b ];
const v3 = _vertexPool[ c ];

// Get homogeneous clip space positions (before perspective divide)
_clipPos1.copy( v1.positionWorld ).applyMatrix4( _viewProjectionMatrix );
_clipPos2.copy( v2.positionWorld ).applyMatrix4( _viewProjectionMatrix );
_clipPos3.copy( v3.positionWorld ).applyMatrix4( _viewProjectionMatrix );

// Check if triangle needs clipping
const nearDist1 = _clipPos1.z + _clipPos1.w;
const nearDist2 = _clipPos2.z + _clipPos2.w;
const nearDist3 = _clipPos3.z + _clipPos3.w;
const farDist1 = - _clipPos1.z + _clipPos1.w;
const farDist2 = - _clipPos2.z + _clipPos2.w;
const farDist3 = - _clipPos3.z + _clipPos3.w;
// Derive near/far clip distances from NDC z and stored clip-space w
// (projectVertex already computed positionScreen = clipPos / w, with w preserved)
const w1 = v1.positionScreen.w;
const w2 = v2.positionScreen.w;
const w3 = v3.positionScreen.w;

const nearDist1 = w1 * ( v1.positionScreen.z + 1 );
const nearDist2 = w2 * ( v2.positionScreen.z + 1 );
const nearDist3 = w3 * ( v3.positionScreen.z + 1 );
const farDist1 = w1 * ( 1 - v1.positionScreen.z );
const farDist2 = w2 * ( 1 - v2.positionScreen.z );
const farDist3 = w3 * ( 1 - v3.positionScreen.z );

// Check if completely outside
if ( ( nearDist1 < 0 && nearDist2 < 0 && nearDist3 < 0 ) ||
Expand Down Expand Up @@ -385,7 +385,10 @@ class Projector {

}

// Triangle needs clipping
// Triangle needs clipping - reconstruct clip-space positions from NDC + w
_clipPos1.set( v1.positionScreen.x * w1, v1.positionScreen.y * w1, v1.positionScreen.z * w1, w1 );
_clipPos2.set( v2.positionScreen.x * w2, v2.positionScreen.y * w2, v2.positionScreen.z * w2, w2 );
_clipPos3.set( v3.positionScreen.x * w3, v3.positionScreen.y * w3, v3.positionScreen.z * w3, w3 );
_clipInputVertices[ 0 ] = _clipPos1;
_clipInputVertices[ 1 ] = _clipPos2;
_clipInputVertices[ 2 ] = _clipPos3;
Expand Down Expand Up @@ -577,7 +580,7 @@ class Projector {

if ( sortObjects === true ) {

painterSortStable( _renderData.objects, 0, _renderData.objects.length );
_renderData.objects.sort( painterSort );

}

Expand Down Expand Up @@ -843,7 +846,7 @@ class Projector {

if ( sortElements === true ) {

painterSortStable( _renderData.elements, 0, _renderData.elements.length );
_renderData.elements.sort( painterSort );

}

Expand Down Expand Up @@ -987,29 +990,6 @@ class Projector {

}

function painterSortStable( array, start, length ) {

// A stable insertion sort for sorting render items
// This avoids the GC overhead of Array.prototype.sort()

for ( let i = start + 1; i < start + length; i ++ ) {

const item = array[ i ];
let j = i - 1;

while ( j >= start && painterSort( array[ j ], item ) > 0 ) {

array[ j + 1 ] = array[ j ];
j --;

}

array[ j + 1 ] = item;

}

}

// Sutherland-Hodgman triangle clipping in homogeneous clip space
// Returns count of vertices in clipped polygon (0 if completely clipped, 3+ if partially clipped)
// Result vertices are in _clipInput array
Expand Down
31 changes: 6 additions & 25 deletions examples/jsm/renderers/SVGRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,29 +300,6 @@ class SVGRenderer {

}

function arraySortStable( array, start, length ) {

// A stable insertion sort for sorting the render list
// This avoids the GC overhead of Array.prototype.sort()

for ( let i = start + 1; i < start + length; i ++ ) {

const item = array[ i ];
let j = i - 1;

while ( j >= start && renderSort( array[ j ], item ) > 0 ) {

array[ j + 1 ] = array[ j ];
j --;

}

array[ j + 1 ] = item;

}

}

/**
* Performs a manual clear with the defined clear color.
*/
Expand Down Expand Up @@ -416,9 +393,13 @@ class SVGRenderer {

} );

if ( this.sortElements ) {
_renderListPool.length = _renderListCount;

if ( this.sortElements && _svgObjectCount > 0 ) {

arraySortStable( _renderListPool, 0, _renderListCount );
// Elements are already sorted by the Projector.
// Only re-sort when SVGObjects need depth-interleaving.
_renderListPool.sort( renderSort );

}

Expand Down