Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,18 @@ describe('generateRegexpWhereSafe', () => {
},
]
const result = generateRegexpWhereSafe(filters, true)
expect(result).toBe("WHERE `request`.`method` = 'get'")
expect(result).toBe("WHERE `request`.`method` = 'GET'")
})

it('should preserve value casing so uppercase HTTP methods match', () => {
const filters: ReportFilterItem[] = [
{
key: 'request.method',
value: 'DELETE',
compare: 'is',
},
]
const result = generateRegexpWhereSafe(filters, true)
expect(result).toBe("WHERE `request`.`method` = 'DELETE'")
})
})
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export function generateRegexpWhereSafe(
const valueIsNumber = !isNaN(Number(filter.value))
const lit = valueIsNumber
? analyticsLiteral(Number(filter.value))
: analyticsLiteral(String(filter.value).toLowerCase())
: analyticsLiteral(String(filter.value))

switch (filter.compare) {
case 'matches':
Expand Down
Loading