[pull] main from microsoft:main#770
Merged
Merged
Conversation
… button (#41244) When a page uses a hidden `<input type="file">` triggered by another element: ```html <button onclick="document.querySelector('input[type=file]').click()">select file</button> <input type="file" style="display: none"> ``` codegen recorded the `setInputFiles` action with the **button's** selector (from `_hoveredModel`, which points to the last visible element the mouse was over) instead of the actual file input's selector. The generated code: ```js // BUG: button is not an HTMLInputElement await page.getByRole('button', { name: 'select file' }).setInputFiles('filename'); ``` fails at runtime with `locator.setInputFiles: Error: Node is not an HTMLInputElement`. The fix: when the `input` event target (the file input element) differs from `_hoveredElement` (the last mouse-hovered element), derive the selector directly from the target via `generateSelector` instead of reusing the hover model. For visible file inputs where the user directly hovers and clicks, `target === _hoveredElement` so existing behaviour is preserved. Fixed output: ```js await page.getByRole('button', { name: 'select file' }).click(); await page.locator('input[type="file"]').setInputFiles('filename'); ``` Fixes #41239
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )