Conversation
…ng unknown module` (#46870) # Why Enabling `asyncRoutes` on Android/iOS breaks every async route in development with errors like: ``` ERROR [Error: Requiring unknown module "1237". If you are sure the module exists, try restarting Metro. ...] ``` This is a regression from #46539, which made `asyncRequire` try a synchronous `importAll()` first, and only fall back to fetching the split bundle when the import _throws_. This only worked for web; on native, the catch-based fallback never runs, the split bundle is never fetched, and the route resolves to `undefined`. # How Added a web-only platform check for the behavior introduced in #46539, and restored the original behavior for native. # Test Plan - CI # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
… safe (#46669) # Why Two concurrent renders currently step on each other's font state, causing issues such as missing `<style id="expo-generated-fonts">` blocks, missing `<link rel="preload" as="font">` tags, or one page's fonts appearing on another. # How - Per-render font store via `AsyncLocalStorage`, scoped by `Server.withServerContext(callback)`. - Both `getStaticContent()` and `getStreamingContent()` use this new font store. - `Font.resetServerContext()` has been removed - Server-side `Font.loadAsync()` outside a scope now throws. Client-side keeps the existing error swallow for `FontObserver` timeouts (see #22954). - Deduplicate by full CSS so `display` (or other CSS-affecting options) produce unique `@font-face` entries. # Test Plan - CI # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )