Conversation
… PNG (#46070) # Why Switching `ios.icon` from a Liquid Glass `.icon` package back to a PNG did not fully converge the native iOS project state. The `.icon` path updates `ASSETCATALOG_COMPILER_APPICON_NAME` to the `.icon` package basename, but the PNG path only regenerates `Images.xcassets/AppIcon.appiconset`. If a project previously used `.icon`, the Xcode build setting could remain pointed at the old `.icon` name, so the latest Expo config was not reflected after rerunning prebuild. # How Updated the iOS icons config plugin so that when an icon is configured and it is not a `.icon` package, the Xcode project app icon build setting is reset to the generated appiconset name. The default app icon name is derived from `IMAGESET_PATH` instead of being separately hardcoded, so the build setting stays aligned with the asset catalog path generated by the plugin. This preserves existing native settings when no icon is configured. # Test Plan Added regression coverage for: - PNG `ios.icon` resets `ASSETCATALOG_COMPILER_APPICON_NAME` from a stale `.icon` name back to the generated appiconset name. - No icon config does not overwrite an existing native app icon build setting. Ran: ```sh pnpm --filter @expo/prebuild-config test -- src/plugins/icons/__tests__/withIosIcons-test.ts --runInBand Result: PASS @expo/prebuild-config src/plugins/icons/__tests__/withIosIcons-test.ts Test Suites: 1 passed, 1 total Tests: 13 passed, 13 total Snapshots: 2 passed, 2 total ``` - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Vojtech Novak <vonovak@gmail.com>
Depends on #47904 - needs to be merged first Updates generated Markdown agent instructions to use the submit-expo-feedback CLI instead of the old docs-send curl endpoint. Prefills the docs page path in the feedback command subject. Adds focused coverage for the generated feedback section and updates the llms stripping fixture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )