[pull] main from withastro:main#586
Merged
Merged
Conversation
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
…tics (#17018) * fix(netlify): match canonical remotePatterns semantics in image CDN regex The generated regexes for Netlify Image CDN's remote_images config were broader than Astro's canonical matchHostname/matchPathname helpers: - *.host patterns used '?' (optional subdomain), allowing the apex host. Changed to required group so exactly one subdomain is required. - **.host patterns used '*' (zero or more), allowing the apex host. Changed to '+' so at least one subdomain is required. - Pathname regexes lacked an end anchor, so .test() could match a URL prefix (e.g. /ok/a inside /ok/a/b.jpg). Added '$' anchor. - The /** and /* branches were not mutually exclusive (if/if instead of if/else if), causing /** to emit a redundant second group. * chore: add changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )