[pull] latest from ag-grid:latest - #853
Merged
Merged
Conversation
* AG-17933-invalid-edit-value-mode-bloxk-with-full-row-fix * AG-17933-invalid-edit-value-mode-bloxk-with-full-row-fix * AG-17933-invalid-edit-value-mode-bloxk-with-full-row-fix * AG-17933-invalid-edit-value-mode-bloxk-with-full-row-fix * AG-17933-invalid-edit-value-mode-bloxk-with-full-row-fix
) * AG-17996 - remove unused trial licence form variants Only the allFields variant was ever rendered: no call site passed a `type` to the TrialLicenceForm dispatcher, so DEFAULT_TRIAL_LICENSE_FORM ('allFields') always won and the emailOnly/original variants were dead. Promote the allFields implementation to TrialLicenceForm and drop the dispatcher along with the now-unused TrialLicenceFormType and DEFAULT_TRIAL_LICENSE_FORM constants. * AG-17996 - add consent fields to trial licence and contact forms Adds the three web-to-lead consent checkboxes to the trial licence and contact forms: - Data Processing Consent - required to submit - Email Marketing Consent - optional - Email Tracking Consent - optional Copy and layout live in a shared ConsentCheckbox component so the wording stays identical across both forms. The contact form posts natively to Salesforce web-to-lead, so its checkboxes are named by Salesforce field ID via CONSENT_FIELD_IDS; the trial form sends the three values in its JSON payload. Email Tracking Consent is shown to everyone for now - the France/Italy geolocation gating will follow separately. * AG-17996 - gate email tracking consent behind a France/Italy self-declaration Email tracking consent only applies to France and Italy. Until IP geolocation is in place, visitors declare their own location: an optional "Please check this box if you live in France or Italy" checkbox reveals the tracking consent checkbox beneath it. Unchecking the declaration also withdraws the tracking consent, so a consent the visitor can no longer see is never submitted, and re-checking always brings the box back unchecked - the legislation requires the opt-in to be unchecked and freely given. * AG-17996 - submit the France/Italy declaration to Salesforce Salesforce now has a field for the France/Italy self-declaration, so the flag is submitted rather than being UI-only. This closes the gap raised in the ticket comments: Salesforce can now tell a French/Italian visitor who declined email tracking from a visitor the checkbox was never shown to. The contact form names the checkbox by Salesforce field ID; the trial form sends it as franceOrItaly in its JSON payload alongside the other consents. * AG-14065 - add trial licence form loading state Applies the changes from PR #14649 onto this branch. - Spinner in the submit button while the request is in flight, with aria-busy for assistive tech and a slowed animation under prefers-reduced-motion - Defines .submit, which the button already referenced but which was never declared in the stylesheet - Drops the styles.isHidden toggle from the field error paragraphs. That class was never declared either, so the toggle was a no-op - visibility comes from .input-error .error. Verified behaviour is unchanged. The three per-variant copies in #14649 collapse into TrialLicenceForm here, since the emailOnly/original variants were removed earlier on this branch. The Studio variant is updated to match. * AG-17996 - Update living in France/Italy text * AG-17996 - Remove redundant privacy message on trial license forms
* AG-18000-grand-total-row-refresh-fix
…14657) The top section reserves vertical space for the advanced filter bar, but GridBodyCtrl.setComp mounted that bar *after* setPinnedRowsHeights had already measured the section, so the height was still 0 on the first pass. Vanilla recovered by accident: it constructs GridHeaderComp after setComp, and the first headerHeightChanged that fires re-runs the layout with the bar's real height. Under React, child refs attach during the mutation phase, so GridHeaderCtrl dispatches that event before the parent effect has created GridBodyCtrl — no listener yet, event lost, and nothing dispatches again. The section kept --ag-top-rows-height: 0px and the first row rendered behind the filter bar. Mount the bar before the section is measured so the height is right on the first pass, and vanilla no longer depends on construction order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )