Conversation
The `editorPos` and `relativePos` properties cause re-layouts because they read the target's bounding client rect. Since very few listeners actually need this, I think we should try to defer these There's a chance this could cause issues if the element is moved during the handler itself but the same would happen if checking the target's dom node directly. Testing looks ok but let's see if there are any weird edge cases I missed
…e user experience Co-authored-by: Copilot <copilot@github.com>
…ffort inline chat: add experiment-controlled reasoning effort and thinking settings
…eholders Add randomized placeholders for new-session chat input
…11632) * feat(chat): add plan review feedback functionality with editor integration Co-authored-by: Copilot <copilot@github.com> * feat(chat): implement plan review feedback functionality with editor actions and UI enhancements Co-authored-by: Copilot <copilot@github.com> * Udpates * Fixes * feat(chat): enhance plan review feedback registration logic to allow feedback only when applicable Co-authored-by: Copilot <copilot@github.com> * Updates --------- Co-authored-by: Copilot <copilot@github.com>
* Refine animated chat input working border - Refactor animated ring to a ::before pseudo-element with mask trick so it can fade in/out via opacity when the .working class toggles - Slow the spin from 1.2s to 3s for a calmer cadence - Replace the static pulsing box-shadow with a 3-step keyframed glow that cycles through the same three theme colors as the conic ring, in sync with the spin (so the halo appears to emanate from the gradient) - Drop the now-unused --chat-input-working-fill override in sessions and the matching entry in the stylelint allowlist * feat(chat): add working border colors for chat input in light and dark themes * feat(chat): update working border colors for chat input * Update src/vs/workbench/contrib/chat/browser/widget/media/chat.css Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat(chat): add transition effect to chat input container --------- Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…essionManager in session services (#311650) chore: update @github/copilot to version 1.0.34 and integrate AutoModeSessionManager in session services
…tion file (#311678) Co-authored-by: Copilot <copilot@github.com>
* Agents - add action to open editor in modal editor group * Add the other action * Simplify action * Update src/vs/sessions/browser/parts/media/editorPart.css Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Pull request feedback --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Agents - add experimental gradient styling for chat send button * Agents - enhance chat send button focus and hover styles for gradient feature * Agents - adjust scale transformation for chat animation effect * style: add gradient animations for chat send button * feat: add experimental gradient styling for chat send button Co-authored-by: Copilot <copilot@github.com> * fix: update experimental gradient setting for chat send button and refine hover styles * fix: update class name for experimental send button gradient in chat styles --------- Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com>
* Fix steer/queue keybinding labels in picker dropdown The queue/steer picker dropdown was showing inverted keybinding labels: e.g. Steer showed 'Alt+Enter' but Enter actually steered. Root cause: ActionWidgetDropdown looked up keybindings via the global IKeybindingService context. The queue/steer keybindings' when-clauses require inChatInput and requestInProgress, which are scoped context keys not visible globally. lookupPrimaryKeybinding fell back to the last registered binding for each the opposite of what was active.command Fix: - Add optional keybinding field to IActionWidgetDropdownAction so callers can override the global lookup with a pre-resolved keybinding. - In ChatQueuePickerActionItem, resolve Enter / Alt+Enter directly and assign them to queue/steer based on the user's configured default, so labels always match what is actually bound. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Use scoped context for keybinding lookup Address PR review: resolve queue/steer dropdown keybinding labels via the scoped contextKeyService instead of hard-coding Enter/Alt+Enter. This respects user customizations and scoped overrides (e.g. editingRequestType when editing a queued/steer request). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add chatInputHasText to lookup overlay; add unit test The keybinding when clauses also require chatInputHasText. Without including it in the overlay used to look up display labels, the picker silently fell back to no label. Add it (the picker is only shown when there is text to send) and add a unit test that asserts the resolved keybinding for both default=steer and default=queue. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Defer EditorMouseEvent position computation
style: adjust padding in chat editor for improved layout Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
…eChange2 (#311688) * Agents - start cleaning up IChatSessionFileChange and IChatSessionFileChange2 * More cleanup * Some more cleanup * Fix hygiene
) * Fix customizations sidebar restoring previous section on reopen When clicking a sidebar category to open the Chat Customizations editor, always reset to the welcome page instead of restoring the previously selected section. This fixes the bug where clicking a different category (e.g. Hooks) after previously viewing another (e.g. Agents) would incorrectly reopen the old section. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * sessions: avoid runtime editor import in customization overview Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/bb6388b9-101e-4ded-af52-a6524bb6ed63 Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
surfacing the item
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )