Conversation
This no longer appears to be used
For #288457 Workaround until we can get core tracking input states properly
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
Remove support for searchable option groups
Fire onDidChange for chat input state changes
* Sessions - add context key to track uncommitted changes * Sessions - show "Mark as Done" when there are no outgoing changes * Pull request feedback * Tweak context keys to avoid flickering
* Add General Purpose agent support behind experiment Add a built-in 'General Purpose' agent to the runSubagent tool, gated behind the 'chat.generalPurposeAgent' experiment treatment: - Add GeneralPurposeAgentName constant - Make agentName required and route undefined/GP names to built-in agent - Render GP agent in automatic instructions agents block - Clean up duplicate DI injection in RunSubagentTool - Add unit tests for GP agent paths * Address PR feedback: fix Event cast, add experiment Emitter, try/catch, deterministic tests - Replace unsafe 'configEvent as Event<void>' cast with dedicated Emitter (fixes tsgo typecheck CI failure) - Fire onDidUpdateToolData when experiment resolution changes the value - Add try/catch around getTreatment in computeAutomaticInstructions - Replace flaky setTimeout(0) in tests with Event.toPromise(onDidUpdateToolData) * Fix merge regression: restore fullLength in toolReferences range calculation The merge conflict resolution incorrectly replaced fullLength with name.length + 1 for toolReference OffsetRange calculation, and removed fullLength from variableReferences test expectations. Restore the original behavior from main. * Apply critical review fixes - Add error handler to _resolveExperiment() preventing unhandled promise rejections when getTreatment fails - Decouple GP agent from SubagentToolCustomAgents config gate so experiment works independently of custom agents setting - Fix redundant parens on Event listener arrow function - Add test for GP agent rendering without custom agents config * Remove unrelated promptsServiceImpl refactor from PR Reset promptsServiceImpl.ts and promptsService.test.ts back to main. These files contained an unrelated refactor (method renames, type simplifications) that was accidentally carried over during the port from PR #295494. * Fix GP agent description: inherit parent tools, not 'all tools'
* Sessions - improve feedback/comments rendering * Pull request feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )