Conversation
…asses Add escapeForCharClass helper to safely interpolate chatVariableLeader and chatAgentLeader into regex character classes, preventing breakage if either leader changes to a regex-special character.
…eader support Test escapeForCharClass for regex character class escaping and computeCompletionRanges with the new regex patterns that accept both leaders. Export escapeForCharClass to enable direct unit testing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use typedLeader instead of hardcoded chatVariableLeader for insertText and label in selection, file/folder, symbol, and tool completions so that @ is fully equivalent to # as a context reference leader. Extract escapeForCharClass, computeCompletionRanges, and isEmptyUpToCompletionWord into chatInputCompletionUtils.ts to allow lightweight unit testing without pulling in the full completions module. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adds a SQLite DB for session-specific metadata. Stores edits in there. It can _almost_ restore edits, but I still need to make undoStops be similarly persisted. That is a project for later this evening.
`LocalAgentsSessionsController` is firing updates on every single response change. This PR tries to reduce this by doing a object equality check before firing the update. In a follow up I'll also see if we can debounce listening to so many request updates
…ession mapping and removing commit method
) * Update chat view layout to bottom-dock controls and adjust styling for improved user experience * Update chat picker styles for improved readability and consistency * Reduce font sizes for chat picker labels to enhance visual consistency * Reduce font sizes for chat picker labels to improve visual consistency * Remove unused header and letterpress elements from chat welcome widget * Center align chat controls and local mode picker for improved layout consistency * Center chat layout and adjust alignment for improved consistency * Enhance workspace picker accessibility with ARIA attributes and improve dropdown interaction * Refactor project picker styles for improved layout and consistency * Remove left margin from workspace picker dropdown label for improved alignment * Simplify dropdown chevron transform for workspace picker * Update new-chat empty state in sessions: remove watermark, center controls, and restyle workspace picker * Refactor chat welcome widget: rename bottom-docked controls to welcome content and update related DOM appends * Update src/vs/sessions/contrib/chat/browser/workspacePicker.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * style: update chat picker styles and add icon rendering for workspace selection * fix: update workspace selection labels for clarity * fix: enhance workspace selection prompt for clarity and render option group pickers on selection * fix: add onDidChangeSelection event to workspace picker for improved selection handling * fix: trigger selection change event when deselecting workspace in picker * fix: hide action widget when clearing workspace selection --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Try to reduce how often LocalAgentsSessionsController fires updates
This test is 30 lines to test that a readonly constant is set
…mptsService (#305727) refactor: streamline access to file and path services in PromptsService
Session types changes and smarter chat to session mapping
Update the built-in HTML sample snippet to follow current web standards and reduce unnecessary boilerplate: - Add lang attribute to <html> tag as first tab stop (W3C recommended) - Remove outdated IE compatibility meta tag (IE is no longer supported) - Remove unnecessary type='text/css' and media='screen' from <link> (default values in HTML5) - Remove <script> tag (modern templates often handle scripts differently) - Move viewport meta before title (following common convention) Fixes #272331 Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
style: update badge background and text color for improved visibility Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com>
style: increase font weight for session title label Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
Delete pointless test
agentHost: add session-specific metadata
* Browser view native "add to chat" features * safe parsing, better pseudo handling
* Don't use trusted telemetry value on model ids * Update src/vs/workbench/contrib/editTelemetry/browser/telemetry/aiEditTelemetry/aiEditTelemetryServiceImpl.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Regex * tests --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ns (#305767) Fix errors about loading customizations in remote agenthost workspaces
* docs - update command center actions in layout spec * sessions: drop Add Chat layout docs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Resolve merge conflict with origin/main. Remove duplicate re-export from chatInputCompletions.ts (line 72) per review feedback. Update notebook.chat.contribution.ts to import directly from chatInputCompletionUtils.ts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Changes - polish changes filter * Add some spacing to the picker * Changes - fix panel rendering when there are no changes
@ can be used to reference context, just like #
add chat import and export icons to agent debug logs
Bumps [picomatch](https://github.com/micromatch/picomatch) from 4.0.3 to 4.0.4. - [Release notes](https://github.com/micromatch/picomatch/releases) - [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md) - [Commits](micromatch/picomatch@4.0.3...4.0.4) --- updated-dependencies: - dependency-name: picomatch dependency-version: 4.0.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
Bumps [picomatch](https://github.com/micromatch/picomatch) from 4.0.3 to 4.0.4. - [Release notes](https://github.com/micromatch/picomatch/releases) - [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md) - [Commits](micromatch/picomatch@4.0.3...4.0.4) --- updated-dependencies: - dependency-name: picomatch dependency-version: 4.0.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
…305343) Bumps [node-forge](https://github.com/digitalbazaar/forge) from 1.3.2 to 1.4.0. - [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md) - [Commits](digitalbazaar/forge@v1.3.2...v1.4.0) --- updated-dependencies: - dependency-name: node-forge dependency-version: 1.4.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [octokit/request-action](https://github.com/octokit/request-action) from 2.4.0 to 3.0.0. - [Release notes](https://github.com/octokit/request-action/releases) - [Commits](octokit/request-action@dad4362...b91aaba) --- updated-dependencies: - dependency-name: octokit/request-action dependency-version: 3.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
Update distro commit to 3431ef6b Co-authored-by: vs-code-engineering[bot] <122617954+vs-code-engineering[bot]@users.noreply.github.com>
… items (#305813) * feat: enhance AICustomizationListWidget with grouping and badge support for external customization items * feat: add user data profile service and infer storage from URI in AICustomizationListWidget * Copilot CLI session 8af2fd4a-10fe-4bba-b408-f1b90cebc8dc changes * docs: add chatSessionCustomizationProvider API chain to customizations editor skill Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: address PR review feedback - Remove duplicate sectionToIcon, reuse getSectionIcon instance method - Use Map for O(1) groupKey lookups instead of O(n²) includes/find - Check active project root in inferStorageFromUri for Sessions window - Set pluginUri on provider items and use it for storage inference - Remove redundant plugin check from inferStorageFromUri (handled by caller) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add experiment for sign in button in title bar
… badges (#305810) * test: add tests for external harness replacement behavior * feat: enhance external customization item handling with storage inference and instruction enrichment * refactor: remove workspaceSubpaths from chat session customization metadata * Copilot CLI session 6be53c25-3ac3-44c2-97f1-846de07165de changes * refactor: extract shared buildInstructionListItem and document provider API Extract the instruction classification logic (applyTo parsing, badge generation, groupKey assignment) into a shared buildInstructionListItem method used by both the built-in and provider item paths. Remove the instruction-specific enrichInstructionItemsFromProvider in favor of inline logic in fetchItemsFromProvider that delegates to the shared helper. Add a section to the chat-customizations-editor skill documenting the chatSessionCustomizationProvider proposed API flow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: address PR review — disposal fallback and agent instruction grouping Fix disposal fallback: when an external harness that overrides a static one is disposed, keep the active harness on the same id since the static harness is restored. Only fall back to all[0] when no harness with that id remains. Fix agent instruction grouping: buildInstructionListItem now detects well-known agent instruction files (AGENTS.md, CLAUDE.md, CLAUDE.local.md, copilot-instructions.md) and assigns groupKey 'agent-instructions' so they appear under the correct header for both built-in and provider items. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * revert: remove skill file edits to avoid merge conflict Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Make sure main thread chat session models use overrides from live model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )