[pull] main from SigNoz:main - #867
Merged
Merged
Conversation
…e) and the v2 dashboards list in the picker (#12291) * fix(ai-assistant): add page context for the V2 panel editor route The V2 panel editor lives on `/dashboard/:dashboardId/panel/:panelId`, which `getAutoContexts` never matched — the three existing dashboard matchers are all `exact`, so a 4-segment URL fell through every branch and the assistant opened with no context chip and a page type of `other`. A saved panel maps to `panel_edit` with its id. The unsaved `panel/new` route has no id to attach yet and the schema requires a non-empty `panel_edit.widgetId`, so it degrades to the dashboard context; the in-progress query and time range still ride along in shared metadata. * fix(ai-assistant): use the v2 dashboards list in the context picker `GET /api/v1/dashboards` is now a stub that returns a V1-deprecated error, and `useGetAllDashboard` routes errors through `useErrorModal` — so opening the picker on the Dashboards tab both showed "Failed to load dashboards" and popped a global error modal. Switch to `useListDashboardsForUserV2`, the same source the V2 list page and export picker already use. `resolveAutoContextName` reads the v2 query key from cache too, so auto-context chips resolve to real dashboard titles again instead of falling back to a generic label. The assistant was the last live caller of the v1 list: the only other one, `container/ListOfDashboard`, is unreachable now that the routed `pages/DashboardsListPage` renders the V2 page. * fix(ai-assistant): report panel_create on the unsaved panel editor `/dashboard/:id/panel/new` previously reported `dashboard_detail`, so the assistant was told the user was looking at a dashboard rather than creating a panel. It now reports `panel_create`, which renders a "New panel" chip. `PageTypeDTO` has no `panel_create` member — `alert_new` is the precedent it's missing — so `resolvePageType` maps it to `panel_edit` until the backend adds one. An unmapped key would fall through to `other` and lose the empty-state chips. The context itself carries no `widgetId`, which the schema only requires when `metadata.page` is literally `panel_edit`. Also drops the `DASHBOARD_WIDGET` matcher. That V1 route is unreachable — nothing generates a link to it since V2 always builds panel-editor paths — and it read the `:widgetId` path segment, which V1's own page ignored in favour of `?widgetId=`, so its `widgetId` was never right.
…andle invalid order by (#12295)
…eCompare crash (#12289) The QueryTable column sorter called `.localeCompare` on values cast with `as string`, which is compile-time only. Upstream `processTableRowValue` normalizes numeric-looking strings to real numbers while null becomes the string "N/A", so a grouped column can mix numbers and text. Comparing a number cell against a text cell skipped the numeric branch and invoked `(200).localeCompare(...)`, throwing "localeCompare is not a function" and crashing the table on sort. Extract the compare logic into `compareTableColumnValues` and coerce both sides with `String(x ?? '')` so any value type sorts safely while preserving empty-string semantics for null/undefined. Affects all QueryTable surfaces: Traces/Logs table views, APM Top Operations, and dashboard Table panels. Fixes SIGNOZ-UI-5GC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )