[pull] main from SigNoz:main - #859
Merged
Merged
Conversation
…se (#12251) * fix(tracedetail): use span-derived bounds for flamegraph EndTimestampMillis The trace_summary MV stores max(timestamp) as 'end', which is the maximum span *start* time. For the final span of a trace, this misses the span's duration entirely, making EndTimestampMillis shorter than the actual trace end. FlamegraphTrace already computed the correct end via updateTimeRange (end = max(span_start + duration)) but only used it internally for bucket sampling. Add TimeRange() to expose these span-derived bounds and use them in both getFullFlamegraph and getWindowedFlamegraph instead of summary.End. The waterfall was unaffected — NewWaterfallTraceFromSpans already computes endTime = max(span.TimeUnix + span.DurationNano) from actual spans. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GxTqz7CqqmoFEPHFqhJUCa * chore: remove unnecessary comments --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
…sh fixes (#12178) * feat(dashboard-v2): compact panel layout before persisting drag and JSON edits * feat(dashboard-v2): resolve and persist user-typed variable selection across refetch * feat(dashboard-v2): expose image field and close-on-Escape in the JSON editor * fix(dashboard-v2): keep a custom dashboard image selectable in the overview picker * fix(dashboard-v2): variable form & bar fixes * fix(dashboard-v2): unify section title modal, keep open on error * refactor(dashboard-v2): dashboard-list tags (popover to tooltip, TagBadge, DashboardRowTags) * fix(dashboard-v2): sync locked state to the detail cache after list-page toggle * fix(dashboard-v2): stop the variable value control from showing scrollbars * fix(dashboard-v2): hide the not-recommended pill below 1280px, not 1024px
…iew dialog (#12181) * fix(dashboard-v2): compose panel filter via ANTLR so apply/remove respect precedence * feat(dashboard-v2): review apply-to-panels query changes in the impact dialog * feat(dashboard-v2): surface non-builder panel queries in the apply-to-panels review findApplyUsages now emits an editable row for every selected panel query that does not yet reference the variable — PromQL/ClickHouse rows default to their current text (never auto-injected) so the review dialog opens for them instead of silently no-op'ing. Adds isVariableAppliedToAllPanels, a cheap boolean scan (no ANTLR) for the 'apply to all' disabled state. * feat(dashboard-v2): route apply-to-all through the review dialog The list-row 'Apply to all' now opens the same VariableImpactDialog review (all panels as target) instead of a plain confirm, and is disabled with an 'Already applied to all panels' tooltip once every panel query references the variable. Removes the now-redundant ApplyToAllDialog and the dead build*VariableToPanelsPatch helpers.
…mmit-on-close) (#12254) * feat(NewSelect): make multi-select Only/All + Toggle real clickable pills * fix(dashboard-v2): reset variable default only on real option-set changes * fix(dashboard-v2): multiselect value selection — commit on close, skip unchanged cascade, allow clear * fix(dashboard-v2): fix multiselect tag layout in the variable pill * fix: format issue * fix(dashboard-v2): clear invalid variable default and fix useVariableForm test OOM Stabilize the useVariableForm test props so the reset-on-`initial` effect no longer loops into a heap OOM (the hook relies on a stable `initial` reference, which memoized callers already provide). With the suite now running, align the QUERY/CUSTOM default-reset to clear an invalidated default to empty rather than pinning the first option, matching the DYNAMIC path and letting resolution fall back to the first option / ALL. * refactor(NewSelect): extract option-row button handler out of JSX Pull the repeated stopPropagation/preventDefault/select/reset logic on the option row's checkbox, Only/All and Toggle buttons into a single `selectFromButton(e, source)` helper so the JSX stays readable.
…on & unified delete modal (#12256) * feat(dashboard-v2): add "Request a new template" header to templates tab * fix(dashboard-v2): keep toolbar tags intact when the dashboard title is long * fix(dashboard-v2): use a subtle outline info icon in the variables bar * fix(dashboard-v2): truncate long dashboard title in the breadcrumb * refactor(dashboard-v2): share one delete-confirm modal for views and dashboards * fix(dashboard-v2): reduce panel area horizontal padding * fix(dashboard-v2): show loader while deleting a saved view Deleting a saved view was fire-and-forget: the confirm modal closed instantly and the row vanished later on refetch, with no loading feedback. Make the delete awaitable end-to-end (deleteView -> removeView -> handleRemoveView -> ViewsRail onConfirm) so the shared confirm modal keeps its Delete button loading until the backend call settles, then closes — matching dashboard delete. The active view resets only on success. * fix(dashboard-v2): fire delete success toast after the list refetches Move the dashboard delete success toast to after the list is invalidated and refetched, so it appears once the row is gone, and use a plain success message. * fix(dashboard-v2): centre the delete-confirm alert icon to match v1 The shared delete-confirm modal top-aligned the CircleAlert (align-items: flex-start + a margin-top nudge) at size 20; centre it against the body (align-items: center) at size 3xl, matching the v1 dashboard delete button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )