[pull] main from SigNoz:main - #854
Merged
Merged
Conversation
* feat: span mapper test endpoint * feat: integrate with collector * fix: more cleanup and integration test * fix: lint * fix: cleanup go.mod * fix: update openapi * fix: more cleanup * fix: update go.mod * fix: minor cleanup * fix: update group_id to groupId * fix: cleanup integration test --------- Co-authored-by: Gaurav Tewari <gauravtewari111@gmail.com>
* fix: fetch latest monotonicty for metrics instead of any random * test: add integration test for is monotonic flag
PR #12137 changed the URL-prefill effect dependency from the primitive `thresholdsFromURL` string to the memoized `urlPrefill` object, which gets a fresh reference on every `location.search` change. On the alert overview/edit page the query builder normalizes the loaded query back into the URL after mount, so the effect re-ran and its unconditional threshold RESET wiped the value loaded via SET_INITIAL_STATE (245 -> 0 on refresh). URL-declared prefill is a create-flow concern; in edit mode the alert state is owned by SET_INITIAL_STATE. Skip the effect when isEditMode is true.
* feat: adding gcp memorystore redis service * refactor: updating dashboard title * refactor: extending width of uptime gauge panel * refactor: updating cpu utilization panel * refactor: updating dashboard panel to use rate function instead of hack
…ashboard v2 spec (#12197) * fix: remove omitempty and omitzero where not needed in dashboard v2 spec * fix: reject explicitly empty enum values if invalid
* test(e2e): cover alert edit-page threshold persistence Adds an E2E test that seeds a notification channel + v2 threshold alert (target 245) via API, opens the alert overview/edit page, and asserts the condition editor shows the persisted threshold value once loaded. New helper tests/e2e/helpers/alerts.ts (channel/alert seed + delete + navigate) mirrors the existing dashboards seeding pattern; the test lives alongside the existing tabs test in tests/e2e/tests/alerts/alerts.spec.ts. Verified against a local --with-web stack (passes with the loaded value, fails when the edit page resets it). * chore: pr review fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )