[pull] main from SigNoz:main - #852
Merged
Merged
Conversation
… lookup) (#12204) * test(e2e): retry network teardown to survive async endpoint detach `--teardown` fails on CI with `docker.errors.APIError: 403 ... error while removing network ... has active endpoints`: containers are torn down before the network, but Docker detaches endpoints asynchronously, so the network can still report active endpoints for a moment. Retry the removal, force-disconnecting any stragglers each round. * test(e2e): resolve keeper coordinator lazily so --teardown doesn't crash `create_clickhouse` / `create_clickhouse_cluster` computed `next(iter(keeper.container_configs.values()))` eagerly. Under `--teardown` the keeper fixture is empty, so it raised StopIteration during teardown setup, before any finalizer ran. Move the lookup inside create().
…es (#12038) * feat(globalTime): add method to reset time of child to parent * refactor(infra-monitoring): extract content from K8sBaseDetails * feat(entity-details): add support to persist custom time across categories of k8s * test(entity-details): update existing tests * test(entity-details): add regression test for time conversion * fix(k8s-list): ensure default value for list is 30m * fix(entity-counts-section): address todo around inherit selected time * fix(pr): missing fix for tab validation, lost of moving/merge
…il pages (#12199) * feat(dashboard-v2): add analytics event catalog for list + detail Introduce DashboardListEvents and DashboardDetailEvents enums as the single source of truth for V2 dashboard product-analytics event names. Grouped action-discriminator events (RowAction, SectionAction, PanelAction, DrilldownAction, JsonEditorAction, PublicDashboardAction) mirror the existing 'Dashboard Detail: Panel action' pattern. PanelAction reuses the existing V1 string so panel actions stay comparable across versions. * feat(dashboard-v2): instrument dashboards list page analytics Fire logEvent for create/import funnel (tab switch, created success, import failed), find/navigate (search, filter, sort, columns, pin, pagination), Views rail (select/save/rename/delete/reset, rail toggle), row actions (view/open-new-tab/copy-link/rename/edit-tags/duplicate/lock/delete), legacy-dashboard dialog, and error-state actions. * feat(dashboard-v2): instrument dashboard detail page analytics Fire logEvent across the detail page: lifecycle (open, rename, clone, delete, lock, full-screen, stale-reload, public-url), sections (add/rename/clone/delete, collapse, reorder, first-section migration), panels (add, edit/clone/delete/move, export csv/png/svg, view, editor save/discard, type change, search, no-data), layout drag/resize (rate-limited), variables setup (save/delete/reorder/test/ apply-to-all) and runtime selection (value selected rate-limited, multiselect clear, options-fetch failed), drill-down (open + view-logs/traces/breakout/ filter/set-variable/create-variable), panel zoom, JSON editor actions, settings overview save/discard, cursor sync, and public-dashboard actions. * fix: lint * refactor(dashboard-v2): extract inline analytics handlers into named functions Address PR review: pull the inline JSX arrow handlers that wrap logEvent out into named handlers across both V2 dashboard pages (public-url open, cursor/ tooltip sync, settings/JSON/full-screen actions, panel search, drilldown view-logs/traces, create-modal tab, error retry/contact-support, row open-in- new-tab/copy-link, legacy contact-support, save-view actions). Behavior unchanged. Handlers defined inside .map()/per-row renderers and pre-existing complex value-mapping handlers (ValueSelector) are intentionally left inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )