Skip to content

[pull] main from TryGhost:main#1100

Merged
pull[bot] merged 3 commits intocode:mainfrom
TryGhost:main
Apr 28, 2026
Merged

[pull] main from TryGhost:main#1100
pull[bot] merged 3 commits intocode:mainfrom
TryGhost:main

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented Apr 28, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

…27592)

no ref

Adds 5 entries to root `pnpm.overrides` that force vulnerable transitive
packages forward. All replacement versions are caret-pinned within the
existing major to avoid cross-major resolution surprises.

## Modules and their callers

| module | range → replacement | caller chain | path type |
|---|---|---|---|
| `form-data` | `<2.5.4` → `^2.5.4` | `e2e > @tryghost/logging >
bunyan-loggly > node-loggly-bulk > request` | dev |
| `growl` | `<1.10.0` → `^1.10.0` | `ghost/admin > ember-mocha > mocha >
growl` | dev |
| `minimist` | `<0.2.4` → `^0.2.4` | `ghost/admin > ember-mocha > mocha
> mkdirp > minimist` | dev |
| `protobufjs` | `<7.5.5` → `^7.5.5` | `e2e > dockerode > protobufjs` |
dev |
| `underscore` | `>=1.3.2 <1.12.1` → `^1.12.1` | `ghost/core >
nodemailer > nodemailer-direct-transport > smtp-connection > httpntlm`
**and** `ghost/core > express-brute > underscore` | **runtime** |

`underscore` is the only runtime-path override here. The bump 1.12 →
1.13 is within the same major; API and function signatures are
unchanged. The two consumers use `underscore` for NTLM SMTP
authentication helpers (narrow runtime use) and inside `express-brute`'s
rate-limiter (runtime).

The remaining critical advisory (`babel-traverse <7.23.2` via
`ghost/admin > @tryghost/ember-promise-modals > ember-auto-import >
babel-core`) has no fix in the affected range — `babel-core` was
deprecated in favor of `@babel/core` years ago. That advisory resolves
only when `ember-auto-import` is bumped to a release that drops
`babel-core`, which is part of the larger Ember toolchain modernization
work.
no ref

Adds 2 entries to root `pnpm.overrides` for transitive packages flagged
as high-severity. Both callers are dev/build chains; no runtime path is
touched. Caret-pinned within the existing major.

| module | range → replacement | caller chain |
|---|---|---|
| `nth-check` | `<2.0.1` → `^2.0.1` | `ghost/admin > cssnano >
cssnano-preset-default > postcss-svgo > svgo > css-select > nth-check` |
| `path-to-regexp` | `<0.1.13` → `^0.1.13` | `e2e > express >
path-to-regexp` |

A `rollup` override was tried in an earlier iteration of this branch but
broke `ghost-admin`'s build (`broccoli-rollup@2.1.1` is tightly coupled
to the rollup 2.79.x return shape and crashed under 2.80.0). The rollup
advisory needs a different fix and is left out of this PR.
no ref

Adds 2 entries to root `pnpm.overrides` for transitive packages flagged
as moderate-severity. Both are patch-level bumps within the existing
major (no version-jump risk).

| module | range → replacement | caller chain |
|---|---|---|
| `follow-redirects` | `<1.16.0` → `^1.16.0` | `. > nx > axios >
follow-redirects` (root dev tooling) |
| `js-yaml` | `>=4.0.0 <4.1.1` → `^4.1.1` | `ghost/i18n > i18next-parser
> js-yaml` |

`follow-redirects` collapses the single resolved instance from `1.15.11` → `1.16.0` (patch). `js-yaml`'s vulnerable `4.1.0` instance is replaced by `4.1.1`; the unrelated `3.14.2` instance pulled by other consumers stays where it is.
@pull pull Bot locked and limited conversation to collaborators Apr 28, 2026
@pull pull Bot added the ⤵️ pull label Apr 28, 2026
@pull pull Bot merged commit eaafc4c into code:main Apr 28, 2026
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant