Conversation
… PRs (#27545) ref https://linear.app/ghost/issue/PLA-33/ Second of the devcontainer series (stacks on top of #27544). Turns the "Reopen in Container → run three commands" flow into "Reopen in Container → done" by shipping the auto-start task with the repo, and recommends the Dev Containers extension on host so newcomers get prompted to install it. Also trims CI for dev-tooling-only PRs: the only things running on this PR (and #27544) should now be Setup and anything with no path filter.
…27547) ref https://linear.app/ghost/issue/PLA-33/ Follow-up to #27544 and #27545. The auto-start flow shipped in #27545 used a `runOn: "folderOpen"` task in `.vscode/tasks.json`, which fires on **host** VS Code too — before the user clicks "Reopen in Container". On a fresh clone the host has no `node_modules`, so the task crashes with `sh: nodemon: command not found` + `Command "nx" not found`, greeting first-time contributors with a wall of red errors. This PR moves auto-start into the **devcontainer lifecycle** so it only fires inside the container, and also fixes a second fresh-clone failure mode discovered while testing: Ghost's backend crashes importing `@tryghost/parse-email-address` because its `build/` output doesn't exist yet.
The `/mail/u/<email>/` path only resolves when that exact address is already signed in at the `<X>` account slot, so Workspace accounts and signed-out users hit a 404 before the `#search` fragment could run. Switched to `/mail/u/0/?authuser=<email>`, which uses Gmail's own account resolver and falls through to the sign-in flow instead of erroring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )