Conversation
ref https://linear.app/ghost/issue/HKG-1709/deduplicate-concurrent-cache-misses - Concurrent cache misses for the same key were each calling fetchData(), causing duplicate upstream queries when a single shared fetch was enough. - This keeps coalescing scoped to the miss path so cache hits still read from Redis independently without unnecessary serialization. - The in-flight map is keyed by internalKey so prefix-hash invalidation remains correct across reset() cycles and stale pre-reset fetches cannot leak into the new cache generation. - When internalKey lookup fails, coalescing is skipped entirely and the degraded path falls back to fetchData() directly.
no issues Follow-up tweaks to #27459: - Scaled the gift event icon down so its footprint matches other event icons, and nudged it up 1px for better optical centering - Moved the tier name out of the action string into the info span so gift redemptions render as `Started paid subscription via gift (Bronze)` — matches the existing `subscription_event` pattern
no issues Dropped "a" from the gift purchase event in member activity which makes it consistent with other events.
ref https://linear.app/ghost/issue/BER-3477 - the previous flow showed a generic **"Gift redeemed! You're all set."** toast and then rendered the Portal account page - now, we don't render the Portal account page after redemption and the toast includes the tier and expiry date (e.g. **"You now have access to Ultra until 27 May 2026. Enjoy!"**) - why: the account page is going to display a call-to-action to "Continue subscription" with a paid subscription for gift subscribers in a follow-up PR. This call-to-action should however not be shown during the gift redemption flow. Therefore, we don't open the account page as part of the gift redemption success state anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )