[pull] master from cube-js:master#436
Merged
pull[bot] merged 2 commits intocode:masterfrom Apr 30, 2026
Merged
Conversation
Replaces the legacy table-based policy editor walkthrough with the new two-column builder centered on Base Role + Global + Deployment permissions. Adds Steps walkthroughs for Viewer/Explorer/Developer flows, documents the auto-bump-to-Developer behaviour, and refreshes the action catalog reference to match what the new builder surfaces. Made-with: Cursor
…uces wrong timestamps on engine v3 (#10779) * fix(schema-compiler): remove AthenaQuery.convertTz override that produces wrong timestamps on engine v3 On Athena engine v3 (Trino-based), CAST(timestamp WITH TIME ZONE AS TIMESTAMP) returns the UTC instant's wall-clock fields, not the local wall-clock at the specified zone. The AthenaQuery.convertTz override used this pattern, silently returning UTC wall-clock instead of the target timezone's wall-clock. Remove the override so AthenaQuery inherits PrestodbQuery.convertTz, which manually shifts by timezone_hour + timezone_minute offsets before casting. Add a unit test to verify AthenaQuery.convertTz uses the manual offset calculation rather than the broken simplified cast. Co-authored-by: Pavel Tiunov <pavel.tiunov@gmail.com> * test(testing-drivers): add E2E test for non-UTC timezone month bucketing Add a testQueries test case that queries ECommerce.count by month with timezone 'Asia/Kolkata'. This exercises the convertTz code path in a full Cube API stack to verify that non-UTC timezones produce correct monthly time dimension bucketing on Athena (and all other drivers). Co-authored-by: Pavel Tiunov <pavel.tiunov@gmail.com> * fix(testing-drivers): use customOrderDateNoPreAgg to avoid pre-aggregation mismatch The non-UTC timezone test was failing because ECommerce.count with orderDate matched the MultiTimeDimForCount pre-aggregation, which was only built for UTC. Switch to customOrderDateNoPreAgg time dimension which has no pre-aggregation, so the query goes directly to the source database and exercises the convertTz code path. Co-authored-by: Pavel Tiunov <pavel.tiunov@gmail.com> * feat(testing-drivers): add snapshot for 'count by month + order with non-UTC timezone (Asia/Kolkata)' test Co-authored-by: Pavel Tiunov <pavel.tiunov@gmail.com> * fix(testing-drivers): use numeric values in MySQL snapshot for count MySQL returns count values as numbers, not strings. Update the snapshot to match MySQL's actual output format. Co-authored-by: Pavel Tiunov <pavel.tiunov@gmail.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )