[pull] master from cube-js:master#405
Merged
pull[bot] merged 2 commits intocode:masterfrom Apr 14, 2026
Merged
Conversation
#10683) Introduce a generic `set_post_commit_callback` on `BatchPipe<S>` that fires after a successful RocksDB commit on the RW-loop thread. This replaces the hard-coded `invalidate_tables_cache` boolean flag, which was a hack that also ran before the actual commit. - `BatchPipe` is now generic over a store type `S` (defaults to `()`), allowing callbacks to receive a typed store reference - `RocksMetaStore::write_operation` passes `&RocksMetaStore` to callbacks, giving them direct access to `cached_tables` and other metastore state - Moved `cached_tables` from `RocksStore` to `RocksMetaStore` where it belongs - Cache invalidation now only happens when the commit actually succeeds - `RocksTable` methods are generic over `S` so they work with any `BatchPipe<S>`
- Remove stale docs-mintlify/data-modeling/ folder (duplicated content) - Move cubes/views diagram to top of Getting Started page - Remove OLAP terminology reference from Concepts page - Add introductory sentence listing key concepts on Concepts page Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )