feat(create-eslint-config): implement setup wizard#51
Open
hanna-skryl wants to merge 3 commits intomainfrom
Open
feat(create-eslint-config): implement setup wizard#51hanna-skryl wants to merge 3 commits intomainfrom
hanna-skryl wants to merge 3 commits intomainfrom
Conversation
matejchalk
reviewed
Apr 20, 2026
Comment on lines
+41
to
+54
| describe('collectAllDeps', () => { | ||
| it('should merge dependencies, devDependencies, and peerDependencies', () => { | ||
| const deps = collectAllDeps({ | ||
| dependencies: { a: '1' }, | ||
| devDependencies: { b: '2' }, | ||
| peerDependencies: { c: '3' }, | ||
| }); | ||
| expect([...deps].toSorted()).toEqual(['a', 'b', 'c']); | ||
| }); | ||
|
|
||
| it('should return an empty set for null input', () => { | ||
| expect(collectAllDeps(null).size).toBe(0); | ||
| }); | ||
| }); |
Contributor
There was a problem hiding this comment.
I'd add a test case for duplicate packages. It's quite common to have the same package in devDependencies (for local development) and peerDependencies (for publishing).
Comment on lines
+7
to
+19
| describe('readJsonFile', () => { | ||
| test('should parse a valid JSON file', async ({ tmp }) => { | ||
| const filePath = path.join(tmp, 'pkg.json'); | ||
| await writeFile(filePath, JSON.stringify({ name: 'foo' })); | ||
| await expect(readJsonFile(filePath)).resolves.toEqual({ name: 'foo' }); | ||
| }); | ||
|
|
||
| test('should return null for a missing file', async ({ tmp }) => { | ||
| await expect( | ||
| readJsonFile(path.join(tmp, 'missing.json')), | ||
| ).resolves.toBeNull(); | ||
| }); | ||
| }); |
Contributor
There was a problem hiding this comment.
I'd add a test case for an existing file with invalid JSON.
Comment on lines
+71
to
+75
| const manager = await detectPackageManager(targetDir); | ||
| logInfo(`Installing dependencies with ${manager}...`, ''); | ||
| try { | ||
| await installDependencies(targetDir); | ||
| } catch (error) { |
Contributor
There was a problem hiding this comment.
The detectPackageManager function is called twice - once here and once in installDependencies.
Comment on lines
+6
to
+16
| /** | ||
| * Vitest test with a per-test `tmp` fixture: a fresh temporary directory | ||
| * that is automatically removed when the test settles. | ||
| */ | ||
| export const test = baseTest.extend<{ tmp: string }>({ | ||
| tmp: async ({ task: _task }, use) => { | ||
| const dir = await mkdtemp(path.join(tmpdir(), 'create-eslint-config-')); | ||
| await use(dir); | ||
| await rm(dir, { recursive: true, force: true }); | ||
| }, | ||
| }); |
Contributor
There was a problem hiding this comment.
I didn't know Vitest had this feature, very cool. 👍
But why not use the recommended builder pattern? 🤔
| }, | ||
| "homepage": "https://github.com/code-pushup/eslint-config/tree/main/packages/create-eslint-config#readme", | ||
| "dependencies": { | ||
| "@inquirer/prompts": "^8.4.1", |
Contributor
There was a problem hiding this comment.
Although this doesn't happen in CI, I get lint errors locally, even after removing node_modules and re-installing.
29:5 error The version specifier does not contain the installed version of "@inquirer/prompts" package: 7.10.1 @nx/dependency-checks
I think it's because @inquirer/prompts isn't installed in the monorepo root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #47
Summary
@code-pushup/eslint-config, triggered vianpm init @code-pushup/eslint-configor imported programmaticallyeslint.config.mjs(or.jsfortype: "module"projects) with preset inheritance--yes,--configs,--tsconfig,--node-version-source,--node-version, and--dry-runCLI flagsNote
Merging into existing
eslint.config.*files is not yet implemented. The wizard prints a snippet for the user to paste manually. HandlingdefineConfigandtseslint.configwrappers will ship in a follow-up. Relevant code is marked with TODO comments.