Fix organizer username in participation request emails - #2511
Open
pttydou wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A brief description of the purpose of the changes contained in this PR.
Participation request emails reused the participant context for organizer recipients, so the base template greeted organizers with the participant username. This sends an individual notification to each active organizer with their own user context while leaving the participant receipt unchanged.
Issues this PR resolves
Fixes #2445
A checklist for hand testing
Any relevant files for testing
src/apps/competitions/tests/test_emails.pyTests:
.venv\Scripts\python.exe -m pytest src/apps/competitions/tests/test_emails.py -qwithDOMAIN_NAME=localhostandDJANGO_SETTINGS_MODULE=settings.test(1 passed).venv\Scripts\python.exe -m flake8 src/(passed)The full Docker/PostgreSQL suite was not run locally because Docker is unavailable on this Windows host; CircleCI covers that suite.
Checklist