Standardize email plain-text templates and link generation - #2510
Open
ihsaan-ullah wants to merge 1 commit into
Open
Standardize email plain-text templates and link generation#2510ihsaan-ullah wants to merge 1 commit into
ihsaan-ullah wants to merge 1 commit into
Conversation
- Add missing plain-text alternative for the account activation email, and send it via EmailMultiAlternatives instead of a plain-text-only EmailMessage. - Rewrite 9 .txt templates that were literal copies of their .html counterparts (wrong , raw HTML tags) into proper plain text extending emails/base_email.txt. - Replace hardcoded + Sites-framework links with across participation, forum, invite, and account-deletion-notice emails; fix links in the account-deletion admin notice that had no scheme at all. - Add get_link_context() in utils/email.py as the single place that builds protocol/domain for email templates, and switch all senders to use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A checklist for email testing
Account activation
Account deletion request
Account deletion — admin notice
Account deletion — confirmed
Competition participation — requested
Competition participation — accepted
Competition participation — denied
Forum new-post notification
Organization invite
General
DOMAIN_NAME/EXTERNAL_DOMAIN_NAMEenv vars on the test server are set correctly<p>,<a>,<ul>etc. in any of the aboveChecklist