Skip to content

Compute Worker - Docker image update check added#2377

Open
ihsaan-ullah wants to merge 3 commits into
developfrom
compute_worker_docker_image_check
Open

Compute Worker - Docker image update check added#2377
ihsaan-ullah wants to merge 3 commits into
developfrom
compute_worker_docker_image_check

Conversation

@ihsaan-ullah
Copy link
Copy Markdown
Collaborator

@ihsaan-ullah ihsaan-ullah commented May 15, 2026

Description

  • This PR adds additional code to compute worker to compare local and remote compute worker images
  • It also has small update to circle-ci config to run flake-8 on compute worker directory

Logs

Compute worker container will show logs like below when this new code runs
Screenshot 2026-05-16 at 1 53 45 AM

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah linked an issue May 15, 2026 that may be closed by this pull request
@ihsaan-ullah ihsaan-ullah changed the title compute worker docker image update checking code added. circle ci con… Compute Worker - Docker image update check added May 15, 2026
@Didayolo
Copy link
Copy Markdown
Member

So this adds warning in the worker logs when the version is not up-to-date?

  • Do we have anything visible on the platform's UI? Like, the logs appear in the submission logs?
  • Can we differentiate mandatory updates from optional updates? (that is maybe not that useful)

@ihsaan-ullah
Copy link
Copy Markdown
Collaborator Author

So this adds warning in the worker logs when the version is not up-to-date?

Yes

  • Do we have anything visible on the platform's UI? Like, the logs appear in the submission logs?

No, this will only be visible in compute worker logs

  • Can we differentiate mandatory updates from optional updates? (that is maybe not that useful)

For now this will only check if local is behind reemote or not. Later on if needed we can somehow differentiate between critical and non-critical updates. This first version do not interact with anything except the docker image on remote(docke hub)

@Didayolo
Copy link
Copy Markdown
Member

Didayolo commented May 18, 2026

I think the warning should be visible on platform side, typically in ingestion_error_logs and scoring_error_logs.

For the "optional or mandatory" update I think it is not that important.

@ihsaan-ullah ihsaan-ullah force-pushed the compute_worker_docker_image_check branch from 252489c to 9cecb23 Compare May 19, 2026 12:58
ihsaan-ullah and others added 2 commits May 26, 2026 11:49
…fig updated to run flake8 on compute worker code

Rabase conflict resolved
@Didayolo Didayolo force-pushed the compute_worker_docker_image_check branch from 562e023 to 1e5ebb9 Compare May 26, 2026 09:49
@Didayolo
Copy link
Copy Markdown
Member

Didayolo commented May 26, 2026

Update:

  • In case of problem we write logs in "scoring error logs" and "ingestion error logs"
  • We check by current container ID instead of just the docker image

The reason for this second point is that, otherwise, if you git pull the latest image but do not restart the container, it will be marked as up-to-date.

The problem with this approach is that in many case the container won't be found by inspect_container just by container ID (typically because of the format "projectname_containername"), so it will throw an error and go back to only checking the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Computer worker upgrade feature

2 participants