Skip to content

Increase Node.js memory limits in entrypoint.sh - #5017

Merged
DMarinhoCodacy merged 2 commits into
masterfrom
Improve-node-resources
Aug 10, 2026
Merged

Increase Node.js memory limits in entrypoint.sh#5017
DMarinhoCodacy merged 2 commits into
masterfrom
Improve-node-resources

Conversation

@DMarinhoCodacy

Copy link
Copy Markdown
Contributor

No description provided.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

While this PR aims to adjust Node.js memory limits, the implementation partially contradicts the title by decreasing the --max-semi-space-size from 128 to 64. Additionally, the PR lacks a description explaining the rationale for these specific values or the removal of the optimization flag.

The current approach hardcodes memory limits, which reduces flexibility across different deployment environments and increases the risk of OOM kills if the container's memory is not significantly higher (20-25%) than the specified heap size. It is highly recommended to use environment variables to allow for dynamic configuration.

About this PR

  • The PR description is empty, providing no justification for the specific memory limits chosen or why the optimization flag was removed. Furthermore, the PR title 'Increase Node.js memory limits' is partially contradicted by the implementation, which halves the --max-semi-space-size.

Test suggestions

  • Verify that the entrypoint.sh script correctly passes the new memory flags to the node executable upon startup.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the entrypoint.sh script correctly passes the new memory flags to the node executable upon startup.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Comment thread entrypoint.sh Outdated
@DMarinhoCodacy
DMarinhoCodacy merged commit 2cbf7ab into master Aug 10, 2026
5 checks passed
@DMarinhoCodacy
DMarinhoCodacy deleted the Improve-node-resources branch August 10, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants