Increase Node.js memory limits in entrypoint.sh - #5017
Conversation
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
While this PR aims to adjust Node.js memory limits, the implementation partially contradicts the title by decreasing the --max-semi-space-size from 128 to 64. Additionally, the PR lacks a description explaining the rationale for these specific values or the removal of the optimization flag.
The current approach hardcodes memory limits, which reduces flexibility across different deployment environments and increases the risk of OOM kills if the container's memory is not significantly higher (20-25%) than the specified heap size. It is highly recommended to use environment variables to allow for dynamic configuration.
About this PR
- The PR description is empty, providing no justification for the specific memory limits chosen or why the optimization flag was removed. Furthermore, the PR title 'Increase Node.js memory limits' is partially contradicted by the implementation, which halves the --max-semi-space-size.
Test suggestions
- Verify that the entrypoint.sh script correctly passes the new memory flags to the node executable upon startup.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the entrypoint.sh script correctly passes the new memory flags to the node executable upon startup.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
No description provided.