fix: restore the SSA inventory applier vk-sandbox consumes - #4
Merged
Conversation
The 8/2 cut read NewSSAInventoryApplier as unwired because nothing in this repo constructs it. vk-sandbox does: it is the only production implementation of the exported InventoryApplier, and pkg/scale ships the publisher toolkit node-side publishers build on. Restored with a test that publishes through a client and asserts one NodeInventory object per node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
87e3263cutNewSSAInventoryApplieras an unwired constructor. It is unwired in this repo — the consumer is vk-sandbox, whosestartInventoryPublisherbuilds it to publish node inventory:So vk-sandbox does not compile against sandbox-operator HEAD. It builds today only because its go.mod still pins
v0.0.0-20260726160753-0c71cfef8125, which predates the cut.pkg/scalepublishes the whole node-side publisher toolkit —NodeInventory,NodeInventoryGVK,InventoryApplier,NodeLiveSource,NewNodeInventoryPublisher— and this was its only production applier;StaticInventorySourceis the in-memory test double. Shipping the toolkit without the applier leaves every out-of-tree publisher hand-rolling SSA against the GVK, which is the drift the type exists to prevent.Restored verbatim, minus the comment the
InventoryAppliergodoc already carries, plusTestSSAApplier_UpsertsOneObjectPerNode: publish through a client, assert the object lands under the node name, republish, assert one object carrying the new entries. Mutation-checked — corrupting the applied name fails the test.Verified:
go build ./...,go test ./...,make lint(0 issues on linux and darwin),asl ./...clean on both GOOS;go build ./...in vk-sandbox under the shared go.work passes again.Follow-up once this lands: bump vk-sandbox's
sandbox-operatorpseudo-version so its pinned build and the workspace build agree.