review: partition declarations so the layout gate passes - #3
Merged
Conversation
Unexported standalone helpers move below the exported set, vocabulary types (PodMutator, failure, Option, ClaimSpec/ClaimResult, PoolSpec/NodePool/NodeInfo) move ahead of the types whose method sets they were splitting, and main / setupTracing / decodeOptional / fanOutNodes / verifySandboxCandidate leave the method sets they were interleaved into. Pure reordering: every touched file keeps an identical set of lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asl ./...reported 31 layout findings across six files — all pre-existing (33 at01300e2, before the 8/2 loc-justify cut), so the gate blocks every commit in this repo regardless of what it touches.Three rules were being broken:
pkg/scale/sandboxstore_impl.go, 8 incontrollers/sandbox_controller.go; they now follow the last exported function of their file.PodMutatorsat betweenSandboxReconcilerandReconcile,failurebetween twoSandboxClaimReconcilermethods,Option/ClaimSpec/ClaimResult/PoolSpec/NodePool/NodeInfoinsideClient's. Vocabulary types now cluster ahead of the type they serve.mainandsetupTracinginsideoptions,decodeOptionalinsideServer,fanOutNodesinsidescatterGatherStore,verifySandboxCandidate/isAdoptableinsidesandboxEventHandler.Pure reordering — no line of code changed. Each touched file holds an identical multiset of non-blank lines before and after (312 insertions / 312 deletions).
Verified:
go build ./...,go test ./...(all pass),make vet,make fmt-check,make lint(0 issues on linux and darwin),asl ./...clean on both GOOS.