review: apply the August asl layout rules - #200
Merged
Conversation
…hod set contiguous asl functypedup: the integrity callback was spelled in two signatures; asl methodinterleave: launchProcess resumed the Firecracker method set after the cloneLeaseControl block, which only its producers may trail.
The parent's half of the lease protocol lived inside start.go's Firecracker method set; moving it beside the child's half in relay.go keeps the launch sequence contiguous without reordering it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asl(CMGS/asl at dc48996) now mechanizes more of the layout rules of the code-style standard; this branch clears every finding it reports on this repository.hypervisor/baseconfig.go,hypervisor/snapshot.go: the integrity callbackfunc(srcDir string, sidecar []*types.StorageConfig) errorwas spelled in bothPreflightRestoresignatures → namedhypervisor.IntegrityCheck(functypedup)hypervisor/firecracker/start.go,hypervisor/firecracker/relay.go: thecloneLeaseControlblock sat inside theFirecrackermethod set, splitting the launch sequence (methodinterleave). It is the parent's half of the relay lease protocol, so it moves beside the child's half inrelay.go;start.gokeeps its original method order.Gates:
asl ./...clean on darwin and linux;go buildandgo veton both GOOS;go test ./hypervisor/...;make lint(golangci-lint v2.12.2) 0 issues on both GOOS.