Repository navigation
Conversation
Both packages target net10.0 and net11.0. The net10.0 assets keep depending on EF Core 10 and Npgsql EF 10; the net11.0 assets depend on EF Core 11 and Npgsql EF 11. Npgsql EF 11 added IQuerySqlGeneratorFactory to the NpgsqlMigrationsSqlGenerator constructor, so the migrations SQL generator takes it on net11.0 only. Relates to cmdscale#71 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With the .NET 11 SDK installed next to 10.0.x, the build uses SDK 11.0.100-rc.3, which resolves a relative --project path a second time against the project directory for multi-targeted projects. The test step then fails with "Could not find a part of the path .../tests/Eftdb.Tests/tests/Eftdb.Tests/Eftdb.Tests.csproj". Passing the path under github.workspace avoids it. The working directory and the other test arguments stay unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #71: both packages now target
net10.0andnet11.0from one branch, with the dependencies chosen per target framework. Thenet10.0assets are unchanged, still on EF Core 10 and Npgsql EF 10. Thenet11.0assets depend on EF Core 11 and Npgsql EF 11. Nothing here is meant as official .NET 11 support: the README's release strategy is untouched.What EF Core 11 required:
IQuerySqlGeneratorFactoryto theNpgsqlMigrationsSqlGeneratorconstructor, soTimescaleDbMigrationsSqlGeneratortakes it under#if NET11_0_OR_GREATER. Without this, the 10.x package throwsMissingMethodExceptionon the firstMigrate()under EF Core 11.IOperationReporterfromMicrosoft.EntityFrameworkCore.Design.InternaltoMicrosoft.EntityFrameworkCore.Design. Package validation therefore reports two CP0002 differences between thenet10.0andnet11.0assets ofEftdb.Design: the constructors ofTimescaleCSharpModelGeneratorandTimescaleDbAnnotationCodeGenerator. Both are built by dependency injection, and the source is the same for both targets, so the differences are suppressed inCompatibilitySuppressions.xml.ExecuteSqlInterpolatedAsyncis obsolete in EF Core 11. The tests callExecuteSqlAsync, which exists on both, so thenet11.0test build adds no warnings.run-tests.yml,release.ymlandsnapshots.yml.Eftdb.FunctionalTestsstays onnet10.0only. EF Core 11'sRelational.Specification.Testsmoved to xUnit v3 (ValueTaskfixtures,Xunit.ITestOutputHelper, noConditionalFact), so running them onnet11.0would mean migrating that project to xUnit v3 first. That would be a separate change if you want it.The EF Core 11 packages are
11.0.0-rc.3for now, sodotnet packwarns NU5104 (stable package depending on a prerelease). I would bump them to 11.0.0 once it is released (expected 2026-11-10), before this is merged.Related Issues
Closes #71
Type of Change
Test Plan
dotnet test)Results:
dotnet test --project tests/Eftdb.Tests -f net10.0: 2707 passed, 0 failed.dotnet test --project tests/Eftdb.Tests -f net11.0: 2707 passed, 0 failed.tests/Eftdb.FunctionalTests(net10.0): 89 passed, 0 failed.The build has 0 errors. Its 2 warnings are both NU5104, from the rc dependency.
Checklist