[Spec 0602][Phase 1] Shared types, monorepo restructure, approved spec + plan#666
Merged
waleedkadous merged 10 commits intomainfrom Apr 13, 2026
Merged
[Spec 0602][Phase 1] Shared types, monorepo restructure, approved spec + plan#666waleedkadous merged 10 commits intomainfrom
waleedkadous merged 10 commits intomainfrom
Conversation
Spec reviewed, consulted (Gemini, Codex, Claude), team feedback incorporated. All open questions resolved. Ready for Plan phase.
8 phases with V1 cut line after Phase 5. Shared types extraction, Connection Manager, terminal integration, unified sidebar, commands. Post-V1: analytics Webview, review comments, file link URI scheme.
…aude) - Split Phase 2 into 2a (connection + auth) and 2b (SSE + auto-start) - Move Review Comments into V1 (Phase 6, zero dependencies) - Add Phase 7: V1 Polish + Packaging (vsce verification) - V1 cut line now Phases 1-7 - Add WebSocket auth control message, proxy support, activation events - Add cross-platform afx open, ws esbuild fix, context menu no-ops - Expand risk table from 7 to 14 risks
…ter rationale - Add Extension Touch Points table (15 VS Code surfaces) - Replace conflicting Cmd+Shift shortcuts with chord bindings (Cmd+K, A/M/G) - Add rationale for native Pseudoterminal over xterm.js Webview - Rename WebSocket Binary Protocol Translation to Binary Protocol Adapter
Plan approved after two rounds of consultation (Gemini, Codex, Claude). Fixes: Cmd+K,D for send (M conflicts), activation event uses .codev/config.json, dependency map self-reference, Phase 8/9 CLI reference, Phase 7 JSON id, explicit ws dependency in Phase 2a, activation time target in Phase 7, UX walkthrough V1 accuracy.
Create @cluesmith/codev-types with WebSocket protocol constants, control message types, SSE event types, and API response shapes. Create @cluesmith/config with shared tsconfig.base.json. - Server ws-protocol.ts imports constants/types from shared package - Extension imports and verifies cross-package resolution - All packages extend config/tsconfig.base.json - Dual exports: types → source (dev), default → dist (runtime)
Post-V1 shared runtime package renamed from @cluesmith/codev-api-client to @cluesmith/codev-shared to host utilities beyond the API client (EscapeBuffer, auth helpers, workspace path encoding).
Move packages/codev/dashboard/ to packages/dashboard/ as a proper workspace member. Dashboard can now import @cluesmith/codev-types. - Build script copies dashboard dist into packages/codev/dashboard-dist/ - Tower runtime path updated to reference dashboard-dist - Test imports use @cluesmith/codev-dashboard package instead of relative paths crossing workspace boundaries - All 2422 tests pass
Rename codev-types → types, codev-vscode → vscode. Folder names drop the codev- prefix (scope provides namespace). npm package names unchanged. Update .vscode/, .gitignore references.
Re-declare FRAME_CONTROL/FRAME_DATA constants locally in ws-protocol.ts to eliminate runtime dependency on @cluesmith/codev-types. Type imports use import type (erased at compile time). Compiled dist has zero imports from codev-types. Global npm install now succeeds.
waleedkadous
approved these changes
Apr 13, 2026
waleedkadous
added a commit
that referenced
this pull request
Apr 13, 2026
… monorepo restructure PR #666 moved the dashboard to packages/dashboard/ and changed the build output from dashboard/dist to dashboard-dist in packages/codev. The npm pack E2E test still expected the old path.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@cluesmith/codev-typesshared types packagepackages/dashboard/as standalone workspace member@cluesmith/codev-configshared tsconfigPackages
packages/codev@cluesmith/codevpackages/types@cluesmith/codev-typespackages/config@cluesmith/configpackages/dashboard@cluesmith/codev-dashboardpackages/vscodecodevTest plan
npm installfrom root resolves all workspace membersnpm run buildin packages/codev passes (including dashboard build + copy)npm test -- --runin packages/codev passes (2422 tests)npm pack+npm install -gfrom tarball succeeds (no codev-types 404)npm run check-typesin packages/vscode passesRef #602