hotfix(doctor): resolve formatBytes duplicate-identifier collision from #1242 × #1243#1248
Merged
Merged
Conversation
waleedkadous
added a commit
that referenced
this pull request
Jul 25, 2026
Picks up the doctor formatBytes hotfix (PR #1248) that was blocking the build.
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is red: PR #1242 and PR #1243 each added a
formatByteshelper and each imported it intodoctor.ts. Git merged the two import statements cleanly (no textual conflict); each PR's CI was green against its own pre-other base; nothing tested the combination (strict=false). Result:TS2300: Duplicate identifier 'formatBytes'— main does not build.Fix (minimal for red-main urgency): alias the session-log-sweep import to
formatLogBytesand move its single call site (line 111) with it. Line 847 keeps the migration-backup formatter. Alias direction chosen deliberately — the two helpers differ at ≥10 units (19.0 GBvs19 GB), so each call site must keep its own module's formatter; both do (credit: air-1239 flagged the silent-rebind trap before it could happen).Verified: full root build green in a clean worktree off broken main (deps installed first — no silent-tsc pass). Zero behavior change.
Follow-up (not this PR): consolidate the two duplicate helpers into one shared util; and consider a merge queue or
strict=true— per-PR required checks structurally cannot catch cross-PR semantic collisions.