Skip to content

chore: Allow borderItemWidth and colorBorderDropdownItemDefault to be themed - #5012

Open
avinashbot wants to merge 1 commit into
mainfrom
core-tokens
Open

avinashbot wants to merge 1 commit into
mainfrom
core-tokens

Conversation

@avinashbot

@avinashbot avinashbot commented Sep 14, 2026

Copy link
Copy Markdown
Member

Description

Follow up from #4986. The core update theme requires certain tokens to be themeable, and these two fell through the cracks. The public: false, themeable: true is on purpose; we have a number of tokens already like that and like the other, this lets us make it "soft"-public first.

Related links, issue #, if available: n/a

How has this been tested?

Tested locally, theming works on these tokens on the scoped-theme dev page without throwing a dev warning.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.66%. Comparing base (4b4d1f4) to head (cd04e18).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5012   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files         960      960           
  Lines       31368    31368           
  Branches    11593    11593           
=======================================
  Hits        30637    30637           
  Misses        685      685           
  Partials       46       46           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avinashbot
avinashbot marked this pull request as ready for review September 15, 2026 16:49
@avinashbot
avinashbot requested a review from a team as a code owner September 15, 2026 16:50
@avinashbot
avinashbot requested review from taheramr and removed request for a team September 15, 2026 16:50
@avinashbot
avinashbot marked this pull request as draft September 15, 2026 16:50
@avinashbot
avinashbot requested review from a team and georgylobko and removed request for a team, georgylobko and taheramr September 15, 2026 16:50
@avinashbot
avinashbot marked this pull request as ready for review September 17, 2026 12:08
@avinashbot
avinashbot requested review from a team and taheramr and removed request for a team September 17, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant