feat: export per-component selectors - #4842
Open
bmv437 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #4750 added per-component export entries for the DOM test-utils wrappers. This adds the
matching entries for the selectors wrappers.
Motivation: consumers who re-export or extend a subset of Cloudscape components need to import
individual wrappers so they can assemble their own
ElementWrapper. Today the only selectorsentry point is the
./test-utils/selectorsbarrel, and importing the barrel adds the finders forevery component to the shared
ElementWrapper. There is no way to narrow that down or removecomponents from it. With per-component entry points, consumers can import just the wrappers they
want. The DOM side already supports this, but selectors did not.
Related links, issue #, if available: n/a
How has this been tested?
Added a unit test for
getComponentsExportsinbuild-tools/tasks/__tests__/package-json.test.jsReview checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.