fix: Prevent focus from being lost when pagination previous/next buttons are disabled#4576
Open
avinashbot wants to merge 2 commits into
Open
fix: Prevent focus from being lost when pagination previous/next buttons are disabled#4576avinashbot wants to merge 2 commits into
avinashbot wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4576 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 941 941
Lines 29692 29696 +4
Branches 10791 10794 +3
=======================================
+ Hits 28930 28934 +4
Misses 715 715
Partials 47 47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The pagination left/right buttons disable themselves when there's no previous or next page after the current page. But this could happen while you're still focused on the left/right navigation buttons, so when you hit the first/last page, the focus could get kicked out while you're still on the button.
Related links, issue #, if available: D460257192
How has this been tested?
Updated unit tests.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.