Skip to content

fix: Prevent focus from being lost when pagination previous/next buttons are disabled#4576

Open
avinashbot wants to merge 2 commits into
mainfrom
pagination-aria-disabled
Open

fix: Prevent focus from being lost when pagination previous/next buttons are disabled#4576
avinashbot wants to merge 2 commits into
mainfrom
pagination-aria-disabled

Conversation

@avinashbot
Copy link
Copy Markdown
Member

@avinashbot avinashbot commented Jun 2, 2026

Description

The pagination left/right buttons disable themselves when there's no previous or next page after the current page. But this could happen while you're still focused on the left/right navigation buttons, so when you hit the first/last page, the focus could get kicked out while you're still on the button.

Related links, issue #, if available: D460257192

How has this been tested?

Updated unit tests.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.43%. Comparing base (370a90e) to head (38ede85).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4576   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files         941      941           
  Lines       29692    29696    +4     
  Branches    10791    10794    +3     
=======================================
+ Hits        28930    28934    +4     
  Misses        715      715           
  Partials       47       47           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avinashbot avinashbot marked this pull request as ready for review June 4, 2026 14:39
@avinashbot avinashbot requested a review from a team as a code owner June 4, 2026 14:39
@avinashbot avinashbot requested review from ernst-dev and removed request for a team June 4, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant