Skip to content

fix: stabilize flaky resizable-columns integration test#4552

Open
amanabiy wants to merge 1 commit into
mainfrom
chore/split-prompt-input-permutations
Open

fix: stabilize flaky resizable-columns integration test#4552
amanabiy wants to merge 1 commit into
mainfrom
chore/split-prompt-input-permutations

Conversation

@amanabiy
Copy link
Copy Markdown
Member

@amanabiy amanabiy commented May 26, 2026

Description

The "should recover column widths when the inner state is reset" test reads column width immediately after clicking #reset-state. React hasn't finished re-rendering at that point, so the test intermittently reads the default width instead of the recovered one.

Fix: replace the immediate read with assertColumnWidth, which polls via waitUntil (1s timeout). Same pattern used by adjacent tests in the file.

Related links, issue #, if available: 8ODfAlKbid05

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@amanabiy amanabiy force-pushed the chore/split-prompt-input-permutations branch from 598dae3 to bc99d2a Compare June 3, 2026 22:12
@amanabiy amanabiy changed the title chore: split prompt-input permutations page into separate files fix: stabilize flaky resizable-columns integration test Jun 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.43%. Comparing base (00a695f) to head (bc99d2a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4552   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files         941      941           
  Lines       29692    29692           
  Branches    10791    10791           
=======================================
  Hits        28930    28930           
  Misses        715      715           
  Partials       47       47           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amanabiy amanabiy marked this pull request as ready for review June 4, 2026 09:01
@amanabiy amanabiy requested a review from a team as a code owner June 4, 2026 09:01
@amanabiy amanabiy requested review from pan-kot and removed request for a team June 4, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant