Skip to content

chore: Make vertical space themeable for input related components#4433

Draft
at-susie wants to merge 12 commits intomainfrom
feat/theme-input
Draft

chore: Make vertical space themeable for input related components#4433
at-susie wants to merge 12 commits intomainfrom
feat/theme-input

Conversation

@at-susie
Copy link
Copy Markdown
Member

Description

This PR introduces a new spaceFieldVertical design token to control vertical padding inside form input components, and removes the fixed block-size constraint from input and property-filter so that input height is driven by padding + content rather than a hard-coded value. Also makes sizeVerticalInput publicly themeable.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@at-susie at-susie marked this pull request as ready for review April 13, 2026 13:11
@at-susie at-susie requested a review from a team as a code owner April 13, 2026 13:11
@at-susie at-susie requested review from ernst-dev and removed request for a team April 13, 2026 13:11
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.39%. Comparing base (fbd8bed) to head (ea2ed2a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4433   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files         928      928           
  Lines       29218    29218           
  Branches    10572    10572           
=======================================
  Hits        28456    28456           
  Misses        715      715           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant