chore: Border width tokens for item selection#4425
Open
Conversation
at-susie
changed the title
at-susie
force-pushed
the
feat/themed-items
branch
from
51196d0 to
b79b283
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4425 +/- ##
=======================================
Coverage 97.39% 97.39%
=======================================
Files 928 928
Lines 29224 29224
Branches 10571 10570 -1
=======================================
Hits 28462 28462
- Misses 715 756 +41
+ Partials 47 6 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
avinashbot
reviewed
Apr 13, 2026
| borderPanelHeaderWidth: { description: 'The split panel header bottom divider width.' }, | ||
| borderPanelTopWidth: { description: 'The split panel top border width.' }, | ||
| borderWidthItemSelected: { | ||
| description: 'The border width of selected items like table', |
Member
There was a problem hiding this comment.
Minor, grammatical: All the other descriptions end in a full stop. The table itself isn't selectable, so it might be better to specify that it's table rows.
So maybe:
Suggested change
| description: 'The border width of selected items like table', | |
| description: 'The border width of selected items, like table rows.', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds themeable tokens for selected item borders.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.