fix: allow text in read-only components to be selected#4417
Open
TrevorBurnham wants to merge 2 commits intocloudscape-design:mainfrom
Open
fix: allow text in read-only components to be selected#4417TrevorBurnham wants to merge 2 commits intocloudscape-design:mainfrom
TrevorBurnham wants to merge 2 commits intocloudscape-design:mainfrom
Conversation
227fc00 to
119d85c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4417 +/- ##
=======================================
Coverage 97.38% 97.38%
=======================================
Files 928 928
Lines 29200 29200
Branches 10565 10564 -1
=======================================
Hits 28435 28435
- Misses 718 759 +41
+ Partials 47 6 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4411
This PR modifies the styles on
DateRangePicker,FileTokenGroup,SelectandMultiselectto make text selectable.Testing
I've added a read-only toggle to the demo pages and was able to manually test each of these.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.