Fix Python 3.14 update_wrapper pickling with lazy annotations#594
Open
BioGeek wants to merge 1 commit into
Open
Fix Python 3.14 update_wrapper pickling with lazy annotations#594BioGeek wants to merge 1 commit into
BioGeek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #585.
Python 3.14 adds
__annotate__tofunctools.WRAPPER_ASSIGNMENTS, sofunctools.update_wrappercan copy a wrapped callable’s lazy annotation function onto wrapper instances. When the wrapped callable is a method on an annotated ABC, that copied__annotate__can close over the class dict and reach_abc_impl, causing:This PR detects the specific redundant
__annotate__copied from__wrapped__and removes it from the object reduction state before pickling.Changes
__annotate__from wrapper instance state when it is identical to__wrapped__.__annotate__.Validation
Tested the original skore==0.11.4 / scikit-learn==1.8.0 reproducer on CPython 3.14.3.
Full test suite: