Update Micronaut parent and add Jackson dependency management entries.#507
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates dependency versions as part of a Jackson-related hotfix and adjusts Kubernetes ConfigMap lookups to use the client’s current namespace (instead of always using "default"), with corresponding test updates.
Changes:
- Update
K8sClient.getConfigMap()to query ConfigMaps in the current Kubernetes namespace and enrich error messages with namespace context. - Adjust
K8sClientTestexpectations to match the namespace used by the Fabric8 mock client. - Bump Micronaut parent and manage/pin Jackson versions; update Jenkins plugin versions.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/test/groovy/com/cloudogu/gitops/infrastructure/kubernetes/api/K8sClientTest.groovy | Updates mocked ConfigMap namespace and request paths to match current-namespace behavior. |
| src/main/groovy/com/cloudogu/gitops/infrastructure/kubernetes/api/K8sClient.groovy | Uses current namespace for ConfigMap reads and improves error context. |
| scripts/jenkins/plugins/plugins.txt | Bumps selected Jenkins plugin versions. |
| pom.xml | Updates Micronaut parent and adds Jackson dependency management entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| */ | ||
| String getConfigMap(String mapName, String key) { | ||
| log.debug("Getting ConfigMap $mapName, key: $key") | ||
| String namespace = getCurrentNamespace() |
Comment on lines
+82
to
+97
| <!-- Source: https://mvnrepository.com/artifact/tools.jackson.core/jackson-databind --> | ||
| <!-- used for com.github.victools:jsonschema-generator --> | ||
| <dependency> | ||
| <groupId>tools.jackson.core</groupId> | ||
| <artifactId>jackson-databind</artifactId> | ||
| <version>3.2.0</version> | ||
| <scope>compile</scope> | ||
| </dependency> | ||
| <!-- Source: https://mvnrepository.com/artifact/tools.jackson.core/jackson-core --> | ||
| <!-- used for com.github.victools:jsonschema-generator --> | ||
| <dependency> | ||
| <groupId>tools.jackson.core</groupId> | ||
| <artifactId>jackson-core</artifactId> | ||
| <version>3.2.0</version> | ||
| <scope>compile</scope> | ||
| </dependency> |
Comment on lines
+100
to
+113
| <dependency> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-core</artifactId> | ||
| <version>2.22.0</version> | ||
| <scope>compile</scope> | ||
| </dependency> | ||
| <!-- Source: https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-databind --> | ||
| <!-- used for io-fabric8, gitlab4j, groovy-yaml and retrofit --> | ||
| <dependency> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-databind</artifactId> | ||
| <version>2.22.0</version> | ||
| <scope>compile</scope> | ||
| </dependency> |
DerDaehne
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.