feat: add pgrouting container image - #299
Open
ofalk wants to merge 5 commits into
Open
Conversation
ofalk
requested review from
GabriFedi97,
NiccoloFei,
armru,
fcanovai,
gbartolini,
leonardoce and
mnencia
as code owners
July 28, 2026 15:09
Author
|
Please have a look @gbartolini ! |
GabriFedi97
reviewed
Jul 29, 2026
Comment on lines
+26
to
+28
| DB_URI=$(echo $DB_URI | sed "s|/\*|/|") | ||
| test "$(psql "$DB_URI" -tAc "SELECT EXISTS (SELECT FROM pg_catalog.pg_extension WHERE extname = 'postgis')" -q)" = "t" | ||
| test "$(psql "$DB_URI" -tAc "SELECT EXISTS (SELECT FROM pg_catalog.pg_extension WHERE extname = 'pgrouting' AND extversion = '${EXT_VERSION}')" -q)" = "t" |
Contributor
There was a problem hiding this comment.
This test assertions are already covered by generic smoke tests:
I believe that adding custom/dedicated tests for an extension should exercise specific aspects of it, like calling a function the extension exposes and verifying the outcome, eg
Author
There was a problem hiding this comment.
Limited (time) bandwidth here... Do you want me to implement this or are you going to add it?
Add pgRouting extension container image for CloudNativePG targeting PostgreSQL 18 across Debian bookworm and trixie distributions. Signed-off-by: Oliver Falk <oliver@linux-kernel.at>
pgRouting is self-contained: its shared library links only against standard libraries already present in the core base image, so the build stage does not need to resolve complex dependencies and stage them into the resulting container. Drop the system-library gathering and the $libdir SQL rewrite and keep a minimal. Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
…fication pgRouting links only against libraries already present in the base image, so the container no longer ships a /system directory. Clear ld_library_path and disable auto_update_os_libs accordingly, keeping metadata.hcl consistent with the simplified Dockerfile. Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Add the CloudNativePG SPDX headers to the Dockerfile, metadata.hcl and README so the extension follows the project's licensing convention, and document the extension licensing in a "Licenses and Copyright" section. Also drop the obsolete ld_library_path from the README Cluster example, since the simplified image no longer ships a /system directory. Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
GabriFedi97
force-pushed
the
feat/add-pgrouting
branch
2 times, most recently
from
July 29, 2026 15:01
ed7f8c7 to
2ef1cea
Compare
List the pgRouting image in the root README so users can discover it alongside the other supported extensions. Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
GabriFedi97
force-pushed
the
feat/add-pgrouting
branch
from
July 29, 2026 15:11
2ef1cea to
a343be6
Compare
GabriFedi97
reviewed
Jul 29, 2026
| | **[pgAudit](pgaudit)** | PostgreSQL audit extension | [github.com/pgaudit/pgaudit](https://github.com/pgaudit/pgaudit) | CNPG maintainers | | ||
| | **[pg_crash](pg-crash)** | **Disruptive** fault injection and chaos engineering extension | [github.com/cybertec-postgresql/pg_crash](https://github.com/cybertec-postgresql/pg_crash) | CNPG maintainers | | ||
| | **[pg_ivm](pg-ivm)** | Incremental View Maintenance for PostgreSQL | [github.com/sraoss/pg_ivm](https://github.com/sraoss/pg_ivm) | @shusaan | | ||
| | **[pgRouting](pgrouting)** | Geospatial routing and network analysis for PostgreSQL/PostGIS | [pgrouting.org](https://pgrouting.org/) | | |
Contributor
There was a problem hiding this comment.
I left the Maintained By column empty on purpose as I'm not sure yet who is going to maintain this extension for this project. The CODEOWNER file needs to be updated accordingly as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add pgRouting extension container image for CloudNativePG targeting PostgreSQL 18 across Debian bookworm and trixie distributions, as discussed in cloudnative-pg/postgis-containers#134
Type of change
Contributor checklist
compliance (
git commit -s).mainbranch of the upstream repository.task checks:allpasses locally.tests pass (e.g.
task bake TARGET=<ext>,task e2e:test:full TARGET=<ext>).// renovate:comments touched inmetadata.hcl/README.mdremainintact (
suite=,depName=,extractVersion=).README.md,BUILD.md, ...) updated where relevant.Maintainer review checklist
// renovate:annotations preserved so automated version tracking keepsworking.
_sharedfilter in.github/workflows/bake.ymlwas updated when all extensions must rebuild.mainand is ready to merge.Closes #300