feat(#850): add extraObjects support to all charts#934
Open
loristo wants to merge 1 commit into
Open
Conversation
Signed-off-by: Loris Torikian <loris_torikian@hotmail.fr>
loristo
requested review from
fcanovai,
gbartolini,
itay-grudev,
leonardoce,
mnencia and
phisco
as code owners
dosubot
Bot
added
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
extraObjectsfeature for all charts in this repository !Initially the issue (#850) was only for the
clusterchart but for the sake of consistency and because it might be useful for all the charts (for Grafana dashboards for instance) I added it to the other 2 charts as well. If you think that this is not needed in the other charts or if you want to separate the feature in multiple issues/commits/PR for the other charts, I'll remove it from thecloudnative-pgandplugin-barman-cloudcharts.