Reuse installed ginkgo and use cleaner binary check - #609
Merged
chombium merged 1 commit intoAug 24, 2026
Conversation
cf-foundation-community-automation
Bot
moved this to Inbox
in Application Runtime Platform Working Group
chombium
requested changes
Mar 2, 2026
chombium
left a comment
chombium
left a comment
Contributor
There was a problem hiding this comment.
Please change the linting directives
|
|
||
| func (c *CAPIClient) HasApp(sourceID, authToken string) bool { | ||
| req, err := http.NewRequest(http.MethodGet, c.addr+"/v3/apps/"+sourceID, nil) | ||
| req, err := http.NewRequest(http.MethodGet, c.addr+"/v3/apps/"+sourceID, nil) //#nosec G704 |
Contributor
There was a problem hiding this comment.
Please use //nolint:gosec instead of #nosec as we are using gosec via golang and not directly.
Contributor
Author
There was a problem hiding this comment.
Good point. There are several instances where there nosec is already used in this code base. Do you want me to change those as well?
Contributor
Author
There was a problem hiding this comment.
There are no more additions of nolint:gosec necessary. I adapted my PR. Also, in the meantime new code has been added using #gosec. I therefore do not think it is a good idea to move away from #nosec in this PR.
jorbaum
commented
Mar 2, 2026
jorbaum
left a comment
jorbaum
left a comment
Contributor
Author
There was a problem hiding this comment.
Worked in the comments.
jorbaum
force-pushed
the
minor-test-script-improvements
branch
4 times, most recently
from
March 3, 2026 15:07
e472868 to
c5a872e
Compare
jorbaum
force-pushed
the
minor-test-script-improvements
branch
2 times, most recently
from
August 24, 2026 12:34
ef4127b to
d7c7db3
Compare
Also: * also fix lint issue with dualstack
jorbaum
force-pushed
the
minor-test-script-improvements
branch
from
August 24, 2026 12:38
d7c7db3 to
4b5e31a
Compare
chombium
approved these changes
Aug 24, 2026
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adjusts test scripts just like cloudfoundry/loggregator-agent-release#717 :
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branch