Skip to content

fix: ruby 4 doesn't include cgi or irb#2784

Merged
mkocher merged 1 commit into
mainfrom
ruby-4-fixes
Jul 16, 2026
Merged

fix: ruby 4 doesn't include cgi or irb#2784
mkocher merged 1 commit into
mainfrom
ruby-4-fixes

Conversation

@mkocher

@mkocher mkocher commented Jul 16, 2026

Copy link
Copy Markdown
Member

What is this change about?

Ruby 4 doesn't include cgi or irb. The CGI dependency can be dropped once prometheus_client is updated.

Please provide contextual information.

prometheus/client_ruby#330
prometheus/client_ruby#329

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3c8cf41a-2fbb-418f-ba16-5ad6c6e84f1a

📥 Commits

Reviewing files that changed from the base of the PR and between 438fd13 and e7be916.

📒 Files selected for processing (1)
  • src/bosh-director/bosh-director.gemspec

Walkthrough

The BOSH Director gemspec now declares irb and cgi as runtime dependencies. Existing runtime dependencies remain unchanged, and the cgi entry includes a comment referencing a Prometheus Ruby issue.

Suggested reviewers: aramprice

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the change and context, but it omits required sections for tests, release notes, breaking change, tags, and AI review feedback. Add the missing template sections: tests run, release note blurb, breaking-change impact, tagged reviewers, and AI review feedback status.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding Ruby 4 compatibility by handling missing cgi and irb dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ruby-4-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mkocher
mkocher merged commit 03ffea2 into main Jul 16, 2026
22 checks passed
@mkocher
mkocher deleted the ruby-4-fixes branch July 16, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants