[wrangler] Add Flagship auto-provisioning#14640
Conversation
🦋 Changeset detectedLatest commit: 13041f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✅ All changesets look good |
|
UnknownError: "Overloaded" |
|
@ericclemmons Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
@cloudflare/autoconfig
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
|
Review posted successfully to PR #14640. Summary of the actionable issue found: Dry-run / inherit handling missing for draft flagship bindings ( |
516e4ae to
1ac9b1b
Compare
1ac9b1b to
fa0b8f6
Compare
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
edmundhung
left a comment
There was a problem hiding this comment.
I'm a bit concerned about making app_id optional here. Flagship has no local implementation and is always routed through the remote binding proxy, which requires an app_id.
With a draft binding such as { binding: "FLAGS" }, wrangler dev would fail to start with FLAGS bindings must have an "app_id" field.
Most draft bindings have a local implementation as a fallback during development, so Flagship is an unusual case here. 🤔
Co-authored-by: Edmund Hung <edmund@cloudflare.com>
Enables https://developers.cloudflare.com/flagship/ bindings for automatic provisioning: https://developers.cloudflare.com/workers/wrangler/configuration/#automatic-provisioning
A picture of a cute animal (not mandatory, but encouraged)
🐯