add new deploy-helpers package to be used in cf cli#14014
Open
emily-shen wants to merge 4 commits into
Open
Conversation
Moves Entry, EphemeralDirectory, AssetsOptions, LegacyAssetPaths types
🦋 Changeset detectedLatest commit: 5290587 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
petebacondarwin
and removed request for
a team
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
emily-shen
force-pushed
the
emily/refactor-pt-2
branch
from
6bf4408 to
658ac2b
Compare
Contributor
|
UnknownError: ProviderInitError |
Contributor
|
@emily-shen Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
emily-shen
force-pushed
the
emily/refactor-pt-2
branch
from
658ac2b to
f349605
Compare
Contributor
|
✅ All changesets look good |
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
emily-shen
force-pushed
the
emily/refactor-pt-2
branch
from
f349605 to
ec42526
Compare
emily-shen
force-pushed
the
emily/refactor-pt-2
branch
from
ec42526 to
5290587
Compare
petebacondarwin
approved these changes
May 22, 2026
Comment on lines
+3
to
+7
| describe("placeholder", () => { | ||
| it("should pass", ({ expect }) => { | ||
| expect(true).toBe(true); | ||
| }); | ||
| }); |
| "scripts": { | ||
| "build": "tsup", | ||
| "check:type": "tsc -p ./tsconfig.json", | ||
| "deploy": "echo 'no deploy'", |
Contributor
There was a problem hiding this comment.
No deploy but prerelease: true?
Do we plan to deploy this to npm? If not, should it just be marked as private: true?
workers-devprod
approved these changes
May 22, 2026
Contributor
workers-devprod
left a comment
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scaffolding the deploy-helpers package, which will be used by the cf-cli.
Inside the deploy-helpers package there is currently only types.
These types are for the merged config/args input that will go into the deploy/upload functions that are shared by cf cli and wrangler. (i haven't added these in yet, but i needed something to go in the package 😅).
I'm not sure what args cf cli will have, and what config shape exactly, so we will just let cf cli do its own config transformation into this intermediate type.
This has also required moving a few more types and utils into workers-utils. This is in the first commit.
I've also added an (unused) flag
--x-deploy-helpersthat will gate the incoming deploy refactor. The plan is to add the new deploy/upload path while keeping the old path around, and the flag can be used as an escape hatch if we have broken anything.A picture of a cute animal (not mandatory, but encouraged)