Skip to content

CC-8419: make directory snapshot id optional - #7039

Draft
flakey5 wants to merge 1 commit into
mainfrom
flakey5/CC-8419
Draft

CC-8419: make directory snapshot id optional#7039
flakey5 wants to merge 1 commit into
mainfrom
flakey5/CC-8419

Conversation

@flakey5

@flakey5 flakey5 commented Aug 17, 2026

Copy link
Copy Markdown
Member

If snapshot is empty, directory will just be prepared to be snapshotted upfront

Draft until internal mr merged

cc @spahl @rushilmehra

If snapshot is empty, directory will just be prepared to be snapshotted
upfront

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
@flakey5
flakey5 requested review from a team as code owners August 17, 2026 21:28
@flakey5
flakey5 requested a review from emily-shen August 17, 2026 21:28
@ask-bonk

ask-bonk Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Model not found: cloudflare-ai-gateway/anthropic/claude-opus-4-6. Did you mean: anthropic/claude-opus-4.5, anthropic/claude-opus-4.6, anthropic/claude-opus-4.7?

github run

@ask-bonk

ask-bonk Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

@flakey5 Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@flakey5
flakey5 marked this pull request as draft August 17, 2026 21:42
@codspeed-hq

This comment was marked as low quality.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.54962% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.37%. Comparing base (bd568a9) to head (28c4664).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/workerd/api/container-test.c++ 88.33% 0 Missing and 14 partials ⚠️
src/workerd/api/container.c++ 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7039      +/-   ##
==========================================
- Coverage   67.80%   67.37%   -0.44%     
==========================================
  Files         468      456      -12     
  Lines      132296   126923    -5373     
  Branches    21474    20734     -740     
==========================================
- Hits        89708    85511    -4197     
+ Misses      29518    28930     -588     
+ Partials    13070    12482     -588     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


// Give the queued start RPC bounded time to run.
for (auto i = 0; i < 10; ++i) {
co_await kj::evalLater([]() {});

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly there's a kj::yield() that you could use, I think

@jasnell jasnell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, AI-reviewer is wonky right now so likely won't get a result from that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants