[build] Prepare workerd for explicit libc++ linkage - #7025
Conversation
|
APIError: Invalid Anthropic API Key |
2 similar comments
|
APIError: Invalid Anthropic API Key |
|
APIError: Invalid Anthropic API Key |
|
@KirillTim Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
8da6ec0 to
6b80b22
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
|
Seems reasonable - would like to discuss the overall motivation for this though. |
Edgeworker now supplies libc++ globally through link_extra_libs rather than toolchain linker flags. Fix the workerd targets that cannot use this dependency directly. Release note: None
6b80b22 to
fc09d08
Compare
Yeah I think this merits some more discussion before moving forward with this approach – this adds complexity for every binary that doesn't use libc++, we should only do this if there's no better alternative. In particular, I think we can use LD_LIBRARY_PATH to avoid needing this. |
Edgeworker now supplies libc++ globally through link_extra_libs rather
than toolchain linker flags. Fix the workerd targets that cannot use
this dependency directly.
Release note: None