Skip to content

[build] Prepare workerd for explicit libc++ linkage - #7025

Open
KirillTim wants to merge 1 commit into
mainfrom
ktimofeev/bazel-hiremtic-libcxx
Open

[build] Prepare workerd for explicit libc++ linkage#7025
KirillTim wants to merge 1 commit into
mainfrom
ktimofeev/bazel-hiremtic-libcxx

Conversation

@KirillTim

Copy link
Copy Markdown
Contributor

Edgeworker now supplies libc++ globally through link_extra_libs rather
than toolchain linker flags. Fix the workerd targets that cannot use
this dependency directly.

Release note: None

@KirillTim
KirillTim requested review from a team as code owners August 16, 2026 22:50
@ask-bonk

ask-bonk Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

2 similar comments
@ask-bonk

ask-bonk Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

@ask-bonk

ask-bonk Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

@ask-bonk

ask-bonk Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

@KirillTim Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@KirillTim
KirillTim force-pushed the ktimofeev/bazel-hiremtic-libcxx branch from 8da6ec0 to 6b80b22 Compare August 16, 2026 23:10
@codspeed-hq

codspeed-hq Bot commented Aug 16, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 129 skipped benchmarks1


Comparing ktimofeev/bazel-hiremtic-libcxx (fc09d08) with main (0cfe647)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Comment thread build/BUILD.sqlite3 Outdated
@npaun

npaun commented Aug 17, 2026

Copy link
Copy Markdown
Member

Seems reasonable - would like to discuss the overall motivation for this though.

Edgeworker now supplies libc++ globally through link_extra_libs rather
than toolchain linker flags. Fix the workerd targets that cannot use
this dependency directly.

Release note: None
@KirillTim
KirillTim force-pushed the ktimofeev/bazel-hiremtic-libcxx branch from 6b80b22 to fc09d08 Compare August 17, 2026 11:55
@fhanau

fhanau commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Seems reasonable - would like to discuss the overall motivation for this though.

Yeah I think this merits some more discussion before moving forward with this approach – this adds complexity for every binary that doesn't use libc++, we should only do this if there's no better alternative. In particular, I think we can use LD_LIBRARY_PATH to avoid needing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants