Increase the SQLite row limit to 4 MiB - #7020
Open
joshthoward wants to merge 1 commit into
Open
Conversation
Contributor
|
APIError: Invalid Anthropic API Key |
2 similar comments
Contributor
|
APIError: Invalid Anthropic API Key |
Contributor
|
APIError: Invalid Anthropic API Key |
Contributor
|
@joshthoward Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
maxmcd
approved these changes
Aug 15, 2026
jasnell
approved these changes
Aug 15, 2026
justin-mp
reviewed
Aug 18, 2026
Comment on lines
-1375
to
+1374
| // This limit is set higher than what is suggested on sqlite.org/security.html | ||
| // because we want to allow storing values of 1MiB, and we added some extra | ||
| // padding on top of that | ||
| sqlite3_limit(db, SQLITE_LIMIT_LENGTH, 2200000); | ||
| // We use most of the suggested limits from sqlite.org/security.html. Note that sqlite3_limit() | ||
| // does NOT return an error code; it returns the old limit. | ||
| sqlite3_limit(db, SQLITE_LIMIT_LENGTH, 4 * 1024 * 1024); |
Contributor
There was a problem hiding this comment.
Previously we allowed 10% over our documented limit for padding. I have no idea what padding we're accounting for. In the KV interface, we cared about V8 serialization overheads, but we don't use V8 serialization with SQLite. SQLite itself might have padding that I don't know about it.
I guess we will need to update our documentation to say that it's 4 MB, inclusive of any padding the system may add under the covers? That seems less satisfying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.