STOR-5542: Allow ctx.abort() to disable alarm retries - #6996
Merged
Conversation
Contributor
|
APIError: Invalid Anthropic API Key |
2 similar comments
Contributor
|
APIError: Invalid Anthropic API Key |
Contributor
|
APIError: Invalid Anthropic API Key |
Contributor
|
@apeacock1991 Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
apeacock1991
force-pushed
the
apeacock/no-retry-alarm-abort
branch
from
August 14, 2026 09:47
03f2449 to
43ddb05
Compare
apeacock1991
marked this pull request as ready for review
August 14, 2026 10:07
apeacock1991
changed the title
petebacondarwin
approved these changes
Aug 14, 2026
petebacondarwin
left a comment
petebacondarwin
left a comment
Contributor
There was a problem hiding this comment.
Approving from a typings point of view
apeacock1991
force-pushed
the
apeacock/no-retry-alarm-abort
branch
from
August 17, 2026 08:26
43ddb05 to
6e9d369
Compare
|
The generated output of |
apeacock1991
commented
Aug 17, 2026
apeacock1991
force-pushed
the
apeacock/no-retry-alarm-abort
branch
from
August 17, 2026 09:42
6e9d369 to
e4d305f
Compare
apeacock1991
changed the title
apeacock1991
force-pushed
the
apeacock/no-retry-alarm-abort
branch
from
August 17, 2026 09:59
e4d305f to
6439f28
Compare
apeacock1991
force-pushed
the
apeacock/no-retry-alarm-abort
branch
from
August 18, 2026 08:56
6439f28 to
9aaae62
Compare
apeacock1991
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6996 +/- ##
==========================================
+ Coverage 67.43% 67.45% +0.01%
==========================================
Files 457 457
Lines 127865 127995 +130
Branches 20918 20940 +22
==========================================
+ Hits 86231 86339 +108
- Misses 28992 29001 +9
- Partials 12642 12655 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jqmmes
reviewed
Aug 19, 2026
jqmmes
approved these changes
Aug 19, 2026
apeacock1991
force-pushed
the
apeacock/no-retry-alarm-abort
branch
from
August 20, 2026 09:51
9aaae62 to
ab9fc37
Compare
Add an ABORTED event outcome and propagate whether an alarm abort should
retry through the runtime layers.
Allow ctx.abort(..., { retryAlarm: false }) to make an alarm terminal.
Preserve replacement alarms queued while asynchronous cleanup is in
progress.
apeacock1991
force-pushed
the
apeacock/no-retry-alarm-abort
branch
from
August 20, 2026 12:17
ab9fc37 to
67dd86a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow Durable Object alarm handlers to call
ctx.abort(reason, { retryAlarm: false })to reset the object without retrying the alarm. Calls without the option retain the existing retry behavior.Add an ABORTED event outcome and preserve the retry decision through both handler and output-gate error paths. Preserve replacement alarms queued while asynchronous abandonment is in progress.