Skip to content

feat: add access context types#6735

Open
BSFishy wants to merge 5 commits intocloudflare:mainfrom
BSFishy:add-access-types
Open

feat: add access context types#6735
BSFishy wants to merge 5 commits intocloudflare:mainfrom
BSFishy:add-access-types

Conversation

@BSFishy
Copy link
Copy Markdown

@BSFishy BSFishy commented May 6, 2026

Replaces #6413 and #6549.

Adds types for Cloudflare Access integration into Workers

@BSFishy BSFishy requested review from a team as code owners May 6, 2026 13:53
@BSFishy BSFishy requested a review from penalosa May 6, 2026 13:53
BSFishy added 5 commits May 6, 2026 14:50
Signed-off-by: Matt Provost <mprovost@cloudflare.com>
Signed-off-by: Matt Provost <mprovost@cloudflare.com>
Signed-off-by: Matt Provost <mprovost@cloudflare.com>
Signed-off-by: Matt Provost <mprovost@cloudflare.com>
this should be more in line with workerd architecture. we separate the
polymorphism to something that AccessContext wraps around rather than
having AccessContext itself be polymorphic.

Signed-off-by: Matt Provost <mprovost@cloudflare.com>
@BSFishy BSFishy force-pushed the add-access-types branch from 75a134f to 057152e Compare May 6, 2026 15:51
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 37.93103% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.60%. Comparing base (ff32115) to head (057152e).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/workerd/api/global-scope.c++ 19.04% 15 Missing and 2 partials ⚠️
src/workerd/api/global-scope.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6735      +/-   ##
==========================================
- Coverage   66.61%   66.60%   -0.02%     
==========================================
  Files         402      402              
  Lines      115908   115933      +25     
  Branches    19427    19430       +3     
==========================================
+ Hits        77209    77213       +4     
- Misses      27097    27120      +23     
+ Partials    11602    11600       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danlapid danlapid requested a review from kentonv May 9, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants